Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote kubelet graceful node shutdown to beta #99735

Merged
merged 1 commit into from Mar 6, 2021

Commits on Mar 5, 2021

  1. Promote kubelet graceful node shutdown to beta

    - Change the feature gate from alpha to beta and enable it by default
    
    - Update a few of the unit tests due to feature gate being enabled by
      default
    
    - Small refactor in `nodeshutdown_manager` which adds `featureEnabled`
      function (which checks that feature gate and that
      `kubeletConfig.ShutdownGracePeriod > 0`).
    
    - Use `featureEnabled()` to exit early from shutdown manager in the case
      that the feature is disabled
    
    - Update kubelet config defaulting to be explicit that
      `ShutdownGracePeriod` and `ShutdownGracePeriodCriticalPods` default to
      zero and update the godoc comments.
    
    - Update defaults and add featureGate tag in api config godoc.
    
    With this feature now in beta and the feature gate enabled by default,
    to enable graceful shutdown all that will be required is to configure
    `ShutdownGracePeriod` and `ShutdownGracePeriodCriticalPods` in the
    kubelet config. If not configured, they will be defaulted to zero, and
    graceful shutdown will effectively be disabled.
    bobbypage committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    893f5fd View commit details
    Browse the repository at this point in the history