Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec credential provider: InteractiveMode support #99310

Merged
merged 3 commits into from Jun 15, 2021
Merged

exec credential provider: InteractiveMode support #99310

merged 3 commits into from Jun 15, 2021

Conversation

ankeesler
Copy link
Contributor

What type of PR is this?

/kind bug

(My guilty conscious is saying that this is really actually a feature, but I am submitting it as a bug because we would like to fix #98451 ASAP)

What this PR does / why we need it:

  • Allow exec plugin authors to control how client-go treats standard input with respect to an exec plugin; this allows for more intelligent handling of standard input
  • Add users.user.exec.interactiveMode to kubeconfig which is used to specify how standard input should be handled in relation to the exec plugin
  • Add ExecCredential.Spec.Interactive to communicate to exec plugin whether standard input was passed to it
  • exec.GetAuthenticator() fails if the exec plugin requires standard input, but it is not available

Which issue(s) this PR fixes:

Fixes #98451

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Exec plugin authors can override default handling of standard input via new interactiveMode kubeconfig field

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig auth
/cc @liggitt @enj

FYI - I have been using https://github.com/ankeesler/sample-exec-plugin to test this manually.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 22, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @ankeesler. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Feb 22, 2021
This was referenced Feb 22, 2021
Closed
Closed
@enj
Copy link
Member

enj commented Feb 22, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 22, 2021
@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Feb 23, 2021
@enj
Copy link
Member

enj commented Feb 26, 2021

/kind feature
/kind api-change
/priority important-longterm
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 26, 2021
@ankeesler ankeesler force-pushed the exec-plugin-interactive branch 2 times, most recently from e5b3e80 to 441ab17 Compare June 9, 2021 20:03
@ankeesler ankeesler mentioned this pull request Jun 9, 2021
Closed
@ankeesler ankeesler force-pushed the exec-plugin-interactive branch 2 times, most recently from 856a1c6 to 4b349da Compare June 14, 2021 21:19
@liggitt
Copy link
Member

liggitt commented Jun 14, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankeesler, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

4 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@ankeesler
Copy link
Contributor Author

Looking into test failure. It might be flake #102842 (comment)

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2021
@ankeesler
exec credential provider: InteractiveMode support
cd83d89 
The value here is that the exec plugin author can use the kubeconfig to assert
how standard input is treated with respect to the exec plugin, e.g.,
- an exec plugin author can ensure that kubectl fails if it cannot provide
  standard input to an exec plugin that needs it (Always)
- an exec plugin author can ensure that an client-go process will still call an
  exec plugin that prefers standard input even if standard input is not
  available (IfAvailable)

Signed-off-by: Andrew Keesler <akeesler@vmware.com>
@ankeesler
kubectl: don't fight for stdin with exec plugins
60246f6 
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
@ankeesler
test/cmd: kubectl and exec plugins don't fight for stdin
e427d2f 
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2021
@ankeesler
Copy link
Contributor Author

pull-kubernetes-integration was an actual test failure, fixed by https://github.com/ankeesler/kubernetes/blob/cd83d89ac94c5b61fdd38840098e7223e5af0d34/test/integration/client/exec_test.go#L693
/hold cancel

pull-kubernetes-unit failure looks like https://storage.googleapis.com/k8s-gubernator/triage/index.html?test=TestMain#bf11e79583121ff73ec4
/test pull-kubernetes-unit

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2021
@liggitt
Copy link
Member

liggitt commented Jun 15, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2021
@ankeesler ankeesler mentioned this pull request Jun 15, 2021
Closed
@k8s-ci-robot k8s-ci-robot merged commit 37da905 into kubernetes:master Jun 15, 2021
SIG Auth Old automation moved this from Changes Requested (v1.22) to Closed / Done Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@enj enj enj requested changes

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.22
SIG Auth
Archived in project
SIG Auth Old
Closed / Done
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

"exec" auth client plugin checks whether STDOUT is interactive to decide whether to forward STDIN
7 participants
@ankeesler @k8s-ci-robot @enj @fedebongio @fejta-bot @sftim @liggitt