[go1.15] Update to go1.15.7 #98363

cpanato · 2021-01-25T12:58:11Z

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Update to go1.15.7

Tracking issue: kubernetes/release#1851
Slack thread: https://kubernetes.slack.com/archives/C2C40FMNF/p1610736817029800

cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- Kubernetes is now built using go1.15.7

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

cpanato · 2021-01-25T12:58:29Z

/triage accepted
/priority important-soon

saschagrunert

/lgtm

xmudrii

/lgtm

justaugustus · 2021-01-25T13:07:40Z

For RelEng:
/lgtm
/approve

/assign @dims

fejta-bot · 2021-01-25T15:41:44Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

justaugustus · 2021-01-25T15:47:31Z

/assign @liggitt
(for staging/ changes)

liggitt · 2021-01-25T15:50:13Z

staging/src/k8s.io/api/admissionregistration/v1/generated.pb.go

@@ -342,13 +342,13 @@ func init() {
 }

 var fileDescriptor_aaac5994f79683e8 = []byte{
-	// 1104 bytes of a gzipped FileDescriptorProto
+	// 1102 bytes of a gzipped FileDescriptorProto


whoa... didn't expect these generation changes... any idea what happened here?

to be honest no 😄

hmm... did we accidentally bump proto generator libraries somehow in one of the build images?

I will go over the PRs, but I don't remember bumping this

for reference:

Build images using Go 1.15.7 release#1857

Update bazel_toolchains to 3.7.2 repo-infra#223

hmm... did we accidentally bump proto generator libraries somehow in one of the build images?

Potentially a result of this PR to enable more arches for kube-cross: kubernetes/release#1853

cc: @dims

@liggitt @justaugustus yep, that's the one. how bad is it?

ok, that explains the diff. would like an ack from node API reviewers that the change in the generated protobuf tag to drop json field name doesn't affect their use

liggitt · 2021-01-25T18:29:21Z

staging/src/k8s.io/kubelet/pkg/apis/podresources/v1/api.pb.go

@@ -363,7 +363,7 @@ func (m *TopologyInfo) GetNodes() []*NUMANode {

 // NUMA representation of NUMA node
 type NUMANode struct {
-	ID                   int64    `protobuf:"varint,1,opt,name=ID,json=iD,proto3" json:"ID,omitempty"`
+	ID                   int64    `protobuf:"varint,1,opt,name=ID,proto3" json:"ID,omitempty"`


would like an ack from @kubernetes/sig-node-api-reviews this doesn't impact any pod resource API serialization

@SergeyKanzhelev @ehashman Can you please ack this change?

I think @AlexeyPerevalov can help here! I also contributed to the feature, digging into the git history to restore the full context.

Just to be clear, there is the same change on thetype Device struct structure in two files above.

My take, but please let's wait for @AlexeyPerevalov 's to confirm, is that we don't need anything special for NUMANode. It should behave like any other podresources API message. Not sure if some setting got lost somewhere. The intent was to just do what the rest of the proto file did. I'll research which settings podresources originally used. Also, thinking about it @RenaudWasTaken took care of the v1alpha1 -> v1 promotion, so he may want to comment here? I'm not sure something changed when moving to v1.

if nothing in the kubelet path uses json proto serialization, then this looks like a no-op change to me

It didn't impact.
podresources is not only the one place, where I found json=iD. I also found it in libopenstorage an d deviceplugin. Probably, it's due to generator modifies the first letter (to lower case)

right. none of those paths use json proto serialization, correct?

right. none of those paths use json proto serialization, correct?

AFAIK nothing uses the json proto

liggitt · 2021-01-25T18:32:43Z

staging/src/k8s.io/api/admissionregistration/v1/generated.pb.go

@@ -342,13 +342,13 @@ func init() {
 }

 var fileDescriptor_aaac5994f79683e8 = []byte{
-	// 1104 bytes of a gzipped FileDescriptorProto
+	// 1102 bytes of a gzipped FileDescriptorProto


ok, that explains the diff. would like an ack from node API reviewers that the change in the generated protobuf tag to drop json field name doesn't affect their use

mrunalp · 2021-01-26T20:40:24Z

Needs rebase

mrunalp · 2021-01-26T20:40:34Z

/approve

liggitt · 2021-01-26T20:45:38Z

/approve

needs rebase/regen

Signed-off-by: Carlos Panato <ctadeu@gmail.com>

cpanato · 2021-01-27T10:52:05Z

rebased @liggitt, PTAL

justaugustus · 2021-01-27T10:56:24Z

/lgtm
/approve

k8s-ci-robot · 2021-01-27T10:56:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, justaugustus, liggitt, mrunalp, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~build/OWNERS~~ [justaugustus,liggitt]
~~cluster/addons/fluentd-elasticsearch/OWNERS~~ [dims,liggitt]
~~staging/publishing/OWNERS~~ [dims,liggitt]
~~staging/src/k8s.io/api/OWNERS~~ [liggitt]
~~staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS~~ [liggitt]
~~staging/src/k8s.io/apimachinery/pkg/apis/OWNERS~~ [liggitt]
~~staging/src/k8s.io/kubelet/OWNERS~~ [liggitt,mrunalp]
~~test/images/OWNERS~~ [dims,liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cpanato mentioned this pull request Jan 25, 2021

Dependency update - Golang 1.15.7 kubernetes/release#1851

Closed

21 tasks

k8s-ci-robot requested review from justaugustus and lavalamp January 25, 2021 13:00

saschagrunert approved these changes Jan 25, 2021

View reviewed changes

k8s-ci-robot assigned saschagrunert Jan 25, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2021

xmudrii approved these changes Jan 25, 2021

View reviewed changes

k8s-ci-robot assigned xmudrii Jan 25, 2021

k8s-ci-robot assigned liggitt Jan 25, 2021

liggitt reviewed Jan 25, 2021

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2021

liggitt reviewed Jan 25, 2021

View reviewed changes

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jan 25, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2021

cpanato added 4 commits January 27, 2021 11:43

[go1.15] Update to go1.15.7

e76fc62

Signed-off-by: Carlos Panato <ctadeu@gmail.com>

[go1.15] staging/publishing: Set default go version to go1.15.7

d4840b9

[go1.15] Use go-runner:buster-v2.2.4 image (built on go1.15.7)

d726c71

[go1.15] updatestaging pb.go files using the hack scripts

3dec578

cpanato force-pushed the go1157 branch from 54150b6 to 3dec578 Compare January 27, 2021 10:51

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2021

k8s-ci-robot merged commit 35bf00a into kubernetes:master Jan 27, 2021

k8s-ci-robot added this to the v1.21 milestone Jan 27, 2021

cpanato deleted the go1157 branch January 27, 2021 11:44

This was referenced Jan 27, 2021

releng(kubekins): Update Golang versions to go1.15.7 kubernetes/test-infra#20623

Merged

[1.20][go1.15] Update to go1.15.7 #98533

Closed

[1.19][go1.15] Update to go1.15.7 #98535

Closed

[1.20][go1.15] Update to go1.15.7 #98567

Closed

github-actions bot mentioned this pull request Feb 3, 2021

Week Ending January 31, 2021 dev-obs/actus#339

Open

cpanato mentioned this pull request Feb 15, 2021

[1.20][go1.15] Update to go1.15.8 #98962

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[go1.15] Update to go1.15.7 #98363

[go1.15] Update to go1.15.7 #98363

cpanato commented Jan 25, 2021

cpanato commented Jan 25, 2021

saschagrunert left a comment

xmudrii left a comment

justaugustus commented Jan 25, 2021

fejta-bot commented Jan 25, 2021

justaugustus commented Jan 25, 2021

liggitt Jan 25, 2021

cpanato Jan 25, 2021

liggitt Jan 25, 2021

cpanato Jan 25, 2021

justaugustus Jan 25, 2021

dims Jan 25, 2021

liggitt Jan 25, 2021

liggitt Jan 25, 2021

dims Jan 25, 2021

ffromani Jan 26, 2021

SergeyKanzhelev Jan 26, 2021

ffromani Jan 26, 2021

liggitt Jan 26, 2021

AlexeyPerevalov Jan 26, 2021

liggitt Jan 26, 2021

RenaudWasTaken Jan 26, 2021

liggitt Jan 25, 2021

mrunalp commented Jan 26, 2021

mrunalp commented Jan 26, 2021

liggitt commented Jan 26, 2021

cpanato commented Jan 27, 2021

justaugustus commented Jan 27, 2021

k8s-ci-robot commented Jan 27, 2021

[go1.15] Update to go1.15.7 #98363

[go1.15] Update to go1.15.7 #98363

Conversation

cpanato commented Jan 25, 2021

cpanato commented Jan 25, 2021

saschagrunert left a comment

Choose a reason for hiding this comment

xmudrii left a comment

Choose a reason for hiding this comment

justaugustus commented Jan 25, 2021

fejta-bot commented Jan 25, 2021

justaugustus commented Jan 25, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrunalp commented Jan 26, 2021

mrunalp commented Jan 26, 2021

liggitt commented Jan 26, 2021

cpanato commented Jan 27, 2021

justaugustus commented Jan 27, 2021

k8s-ci-robot commented Jan 27, 2021