Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all bash custom completions to Go #96087

Merged
merged 8 commits into from Jun 26, 2021
Merged

Move all bash custom completions to Go #96087

merged 8 commits into from Jun 26, 2021

Commits on Jun 6, 2021

  1. refactor: implement custom completions for some flags using Go 

    Only --context, --cluster, --user and --namespace are included.

Signed-off-by: knight42 <anonymousknight96@gmail.com>
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
    @knight42 @marckhouzam
    knight42 authored and marckhouzam committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    663b13e View commit details
    Browse the repository at this point in the history

  2. Move all completion bash code to Go code 

    Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
    @marckhouzam
    marckhouzam committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    879cdc5 View commit details
    Browse the repository at this point in the history

  3. Add Go tests for custom completions 

    Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
    @marckhouzam
    marckhouzam committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    c0b3a69 View commit details
    Browse the repository at this point in the history

  4. Update staging/src/k8s.io/kubectl/pkg/cmd/config/config.go 

    Co-authored-by: Philipp Stehle <philipp.stehle@sap.com>
    @marckhouzam @phil9909
    marckhouzam and phil9909 committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    9d03185 View commit details
    Browse the repository at this point in the history

  5. Join common functions for completion 

    Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
    @marckhouzam
    marckhouzam committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    9625872 View commit details
    Browse the repository at this point in the history

  6. Revert "Add Go tests for custom completions" 

    This reverts commit 0e18f0380042b652996d795559bfb818698abec3.
    @marckhouzam
    marckhouzam committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    1babcea View commit details
    Browse the repository at this point in the history

  7. Add tests for completion utility functions 

    Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
    @marckhouzam
    marckhouzam committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    46aa604 View commit details
    Browse the repository at this point in the history

  8. Use native zsh completion 

    Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
    @marckhouzam
    marckhouzam committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    77bb053 View commit details
    Browse the repository at this point in the history