New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop managed fields from audit entries #94986
drop managed fields from audit entries #94986
Conversation
Hi @tkashem. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @sttts |
451aea7
to
6697f53
Compare
6697f53
to
659f0b8
Compare
c61ca20
to
b629fb9
Compare
76cd879
to
dd9e9bc
Compare
dd9e9bc
to
ba52c20
Compare
API changes have been made according to the KEP - kubernetes/enhancements#2982. This is ready for another pass. |
/hold cancel as discussed, KEP update has been done |
/lgtm |
/assign @liggitt for API approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
audit policy config lgtm
return nil, false, nil | ||
} | ||
|
||
copy := obj.DeepCopyObject() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we know the relative cost (cpu/allocs) of adding a deep copy into the audit pipeline by enabling the omitManagedFields option globally?
drop the managed fields of the objects from the audit entries when we are logging request and response bodies.
ba52c20
to
bbc5934
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sttts, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implements kubernetes/enhancements#2982
This PR adds a new field
OmitManagedFields
to bothaudit.Policy
andaudit.PolicyRule
so cluster operators can opt in to omit managed fields of the request and response bodies from being written to the API audit log.Does this PR introduce a user-facing change?: