-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change at which level klog.Fatal is invoked #94663
Conversation
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/retest |
/retest |
/assign @sallyom |
/lgtm |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
/kind bug
/kind cleanup
/kind regression
/sig cli
/priority important-longterm
What this PR does / why we need it:
With klog/v2 and specifically this PR: kubernetes/klog#79 we suddenly are logging excessive amount of data at level 2 already. Example is, when any command returns an error and it was invoked with
-v=2
the error will be accompanied with full stack trace, example:This PR proposes to delay that stack to
-v=4
since levels 1 and 2 are mostly used for information purposes and having this there seems an overkill. If you use kubectl prior to 1.19 those are not printed at all.Special notes for your reviewer:
/assign @pwittrock @seans3
Does this PR introduce a user-facing change?: