Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Podresources: add Watch() API #94612

Closed
wants to merge 4 commits into from
Closed

WIP: Podresources: add Watch() API #94612

wants to merge 4 commits into from

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Sep 8, 2020 •
edited

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:
Extend the podresources protocol with a Watch() API to to enable monitoring agents to be notified of resource allocation
changes. This new API is intended to be used together with the existing List() endpoint.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
See kubernetes/enhancements#1926 for the KEP extension and more rationale

Does this PR introduce a user-facing change?:

Add Watch() to the podresources API to let monitoring agents to be notified of the resource allocation changes.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/compute-device-assignment.md

@ffromani
podresources: add Watch function
ece2f72 
TBD

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
e2e: node: split out SRIOV utils
14db721 
TBD

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
e2e: node: bootstrap podresources tests
a9184e1 
Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
e2e: node: podresources: start Watch() tests
8c0e617 
Signed-off-by: Francesco Romani <fromani@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 8, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @fromanirh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 8, 2020
@ffromani
Copy link
Contributor Author

ffromani commented Sep 8, 2020

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/kubelet area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 8, 2020
@ffromani
Copy link
Contributor Author

ffromani commented Sep 8, 2020 •
edited

TODOs:

  • more testing of the Watch() changes (kubelet server.go)
  • review the events flow

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fromanirh
To complete the pull request process, please assign sjenning
You can assign the PR to them by writing /assign @sjenning in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ffromani ffromani mentioned this pull request Sep 8, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2020
@k8s-ci-robot
Copy link
Contributor

@fromanirh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani ffromani mentioned this pull request Oct 20, 2020
Merged
@ffromani
Copy link
Contributor Author

replaced by #95734

@ffromani ffromani closed this Oct 20, 2020
@swatisehgal swatisehgal mentioned this pull request Nov 8, 2021
Closed
@ffromani ffromani deleted the podresources-add-watch branch July 17, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karan karan Awaiting requested review from karan

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees
No one assigned
Labels
area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ffromani @k8s-ci-robot