Introduce promlint to guarantee metrics follow Prometheus best practices

[RainbowMango]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Introduce the Prometheus tool promlint to guarantee metrics follow best practices.

Which issue(s) this PR fixes:
Follow up: #85173 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[RainbowMango]

/cc @brancz
@coffeepac

Please take a look.

[brancz]

Wow that was super fast! Very awesome!

/lgtm
/approve

[RainbowMango]

Then, please @liggitt review dependency changes.
/assign @liggitt

[RainbowMango]

@brancz
I think we should introduce promlint as soon as possible to avoiding new metrics to violate the practice. How about we push forward by replicate the checks by ourselves as per @liggitt 's suggestion?

By the way, I don't know how to do with a binary for this...

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/component-base/metrics/OWNERS [RainbowMango,brancz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RainbowMango]

/test pull-kubernetes-verify

[RainbowMango]

/test pull-kubernetes-e2e-gce-device-plugin-gpu
/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

[RainbowMango]

@brancz Please take a look again.
In favor of #90582, we don't need to import Prometheus anymore.

/priority important-soon
/milestone v1.19

[RainbowMango]

/cc @coffeepac @ehashman @logicalhan
Please take a look, #85173 still waiting for this.

[brancz]

Really awesome! lgtm 👍

Once in place, could we open issues for each of these violations? (maybe bundled per component)

/lgtm

[RainbowMango]

/test pull-kubernetes-conformance-kind-ga-only-parallel

Once in place, could we open issues for each of these violations? (maybe bundled per component)

Sure. I'll clean up all legacy metrics which violate the rules once then.

[dims]

test ... ignore me!

[RainbowMango]

I caught you @dims :) :) :)

[dims]

LOL @RainbowMango

[dims]

just so you know... i have this PR in my dashboard ( https://gubernator.k8s.io/pr ) and i am trying to see if a new event helps my dashboard pull latest status (and drop it from my queue since this is already merged! )

:)

[RainbowMango]

Good to know. I never heard of the dashboard before. But seems this PR in my dashboard too with the status Needs Review.

[dims]

dang! i can't get rid of this :)

[RainbowMango]

neither can I.
But I guess there is hidden button named ACK at the end of the item. Maybe you can get rid of this by clicking the button, and you might need to see the button first, e.g. unassign some people to shorten the item.
miracles~