Add --profiling flag to kubelet #84397

xiaoanyunfei · 2019-10-26T09:12:43Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

add kubelet --profiling flag, separate`/debug/pprof/` from debugging handlers

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig node

fejta-bot · 2019-10-26T16:21:34Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

xiaoanyunfei · 2019-10-27T09:40:24Z

/assign @erictune @Random-Liu

cmd/kubelet/app/options/options.go

pkg/kubelet/server/server.go

cmd/kubelet/app/options/options.go

staging/src/k8s.io/kubelet/config/v1beta1/types.go

dims · 2019-11-16T16:27:21Z

/uncc

SaranBalaji90 · 2020-01-15T18:32:52Z

@xiaoanyunfei just curious, if you happen to follow up on this with sig/node?

xiaoanyunfei · 2020-01-16T04:35:51Z

@xiaoanyunfei just curious, if you happen to follow up on this with sig/node?

en, I just browse the issue with label sig/node

SaranBalaji90 · 2020-01-21T23:14:57Z

We did discuss about this PR as part of our sig-node meeting on Jan 21st. I confirmed from the maintainers that we don't need command line argument for this change. I'm not sure about moving this out similar to what we decided for disabling /logs endpoint.

fejta-bot · 2020-04-20T23:34:21Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

k8s-ci-robot · 2020-05-13T11:40:00Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaoanyunfei
To complete the pull request process, please assign derekwaynecarr, erictune
You can assign the PR to them by writing /assign @derekwaynecarr @erictune in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

cmd/kubelet/OWNERS
pkg/kubelet/OWNERS
staging/src/k8s.io/kubelet/config/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SaranBalaji90 · 2020-07-06T22:37:55Z

@xiaoanyunfei you might want to address the following two comments

Remove cmd line flag as this has been deprecated.
Set the default value to true so that the change is backward compatible.

SaranBalaji90 · 2020-07-20T20:06:23Z

pkg/kubelet/server/server.go

-		if enableContentionProfiling {
-			goruntime.SetBlockProfileRate(1)
+		if enableProfiling {
+			server.InstallProfilingHandlers()


nit: Would be nice to say "profiling is disabled" when enableProfiling is false and debuggingHandler is enabled. Can you also add a unit test for this change.

k8s-ci-robot · 2020-08-19T02:45:39Z

@xiaoanyunfei: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu	b957f7f9a6abad2a899e234b70c8601e73630ab4	link	`/test pull-kubernetes-e2e-gce-device-plugin-gpu`
pull-kubernetes-e2e-gce-ubuntu-containerd	`cd989df`	link	`/test pull-kubernetes-e2e-gce-ubuntu-containerd`
pull-kubernetes-e2e-kind	`cd989df`	link	`/test pull-kubernetes-e2e-kind`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fejta-bot · 2020-09-18T03:06:47Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

k8s-ci-robot · 2020-09-18T03:06:54Z

@xiaoanyunfei: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2020-10-18T03:49:41Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2020-10-18T03:49:53Z

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SaranBalaji90 · 2021-01-23T16:14:51Z

@xiaoanyunfei I will be happy to drive this if you're not working on it currently.

SaranBalaji90 · 2021-01-27T05:04:04Z

@xiaoanyunfei I created PR #98458 to address the issue. if you prefer we can continue with this PR as well. Thank you!

xiaoanyunfei · 2021-01-29T06:12:26Z

@xiaoanyunfei I created PR #98458 to address the issue. if you prefer we can continue with this PR as well. Thank you!

OK

k8s-ci-robot requested review from derekwaynecarr and dims October 26, 2019 09:14

xiaoanyunfei force-pushed the feature/kubelet-profiling-flag branch 2 times, most recently from 7c7b53d to a6969d4 Compare October 26, 2019 15:13

k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 26, 2019

xiaoanyunfei force-pushed the feature/kubelet-profiling-flag branch 2 times, most recently from 5a8b2aa to b8c1e45 Compare October 27, 2019 08:33

k8s-ci-robot assigned erictune and Random-Liu Oct 27, 2019

micahhausler reviewed Oct 29, 2019

View reviewed changes

cmd/kubelet/app/options/options.go Outdated Show resolved Hide resolved

pkg/kubelet/server/server.go Outdated Show resolved Hide resolved

xiaoanyunfei force-pushed the feature/kubelet-profiling-flag branch from b8c1e45 to 6b421c0 Compare October 30, 2019 01:51

micahhausler reviewed Oct 30, 2019

View reviewed changes

cmd/kubelet/app/options/options.go Outdated Show resolved Hide resolved

SaranBalaji90 reviewed Nov 10, 2019

View reviewed changes

staging/src/k8s.io/kubelet/config/v1beta1/types.go Outdated Show resolved Hide resolved

k8s-ci-robot removed the request for review from dims November 16, 2019 16:27

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2020

xiaoanyunfei force-pushed the feature/kubelet-profiling-flag branch from 6b421c0 to 299b648 Compare May 13, 2020 11:36

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2020

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2020

SaranBalaji90 mentioned this pull request Jun 23, 2020

Add support for disabling /logs endpoint in kubelet #87273

Merged

xiaoanyunfei force-pushed the feature/kubelet-profiling-flag branch from 299b648 to c5dd24b Compare July 8, 2020 13:32

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 8, 2020

xiaoanyunfei force-pushed the feature/kubelet-profiling-flag branch 2 times, most recently from a15536e to b957f7f Compare July 13, 2020 12:15

SaranBalaji90 reviewed Jul 20, 2020

View reviewed changes

xiaoanyunfei force-pushed the feature/kubelet-profiling-flag branch 2 times, most recently from 11d4716 to 8441741 Compare August 18, 2020 14:03

Add --profiling flag to kubelet

cd989df

xiaoanyunfei force-pushed the feature/kubelet-profiling-flag branch from 8441741 to cd989df Compare August 19, 2020 01:27

k8s-ci-robot closed this Oct 18, 2020

SaranBalaji90 mentioned this pull request Dec 4, 2020

REQUEST: New membership for SaranBalaji90 kubernetes/org#2365

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add --profiling flag to kubelet #84397

Add --profiling flag to kubelet #84397

xiaoanyunfei commented Oct 26, 2019

fejta-bot commented Oct 26, 2019

xiaoanyunfei commented Oct 27, 2019

dims commented Nov 16, 2019

SaranBalaji90 commented Jan 15, 2020

xiaoanyunfei commented Jan 16, 2020

SaranBalaji90 commented Jan 21, 2020 •

edited

fejta-bot commented Apr 20, 2020

k8s-ci-robot commented May 13, 2020

SaranBalaji90 commented Jul 6, 2020 •

edited

SaranBalaji90 Jul 20, 2020

k8s-ci-robot commented Aug 19, 2020

fejta-bot commented Sep 18, 2020

k8s-ci-robot commented Sep 18, 2020

fejta-bot commented Oct 18, 2020

k8s-ci-robot commented Oct 18, 2020

SaranBalaji90 commented Jan 23, 2021

SaranBalaji90 commented Jan 27, 2021

xiaoanyunfei commented Jan 29, 2021

Add --profiling flag to kubelet #84397

Add --profiling flag to kubelet #84397

Conversation

xiaoanyunfei commented Oct 26, 2019

fejta-bot commented Oct 26, 2019

xiaoanyunfei commented Oct 27, 2019

dims commented Nov 16, 2019

SaranBalaji90 commented Jan 15, 2020

xiaoanyunfei commented Jan 16, 2020

SaranBalaji90 commented Jan 21, 2020 • edited

fejta-bot commented Apr 20, 2020

k8s-ci-robot commented May 13, 2020

SaranBalaji90 commented Jul 6, 2020 • edited

SaranBalaji90 Jul 20, 2020

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 19, 2020

fejta-bot commented Sep 18, 2020

k8s-ci-robot commented Sep 18, 2020

fejta-bot commented Oct 18, 2020

k8s-ci-robot commented Oct 18, 2020

SaranBalaji90 commented Jan 23, 2021

SaranBalaji90 commented Jan 27, 2021

xiaoanyunfei commented Jan 29, 2021

SaranBalaji90 commented Jan 21, 2020 •

edited

SaranBalaji90 commented Jul 6, 2020 •

edited