Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.13] Automated cherry pick of #83261: bump gopkg.in/yaml.v2 v2.2.4 #83436

Merged
merged 2 commits into from Oct 4, 2019
Merged

[1.13] Automated cherry pick of #83261: bump gopkg.in/yaml.v2 v2.2.4 #83436

merged 2 commits into from Oct 4, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 3, 2019

Cherry pick of #83261 on release-1.13.

#83261: bump gopkg.in/yaml.v2 v2.2.4

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 3, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 3, 2019
@liggitt
Copy link
Member Author

liggitt commented Oct 3, 2019

/assign @cjcullen @caesarxuchao
/kind bug
/priority critical-urgent
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 3, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 3, 2019
@liggitt liggitt changed the title Automated cherry pick of #83261: bump gopkg.in/yaml.v2 v2.2.4 [1.13] Automated cherry pick of #83261: bump gopkg.in/yaml.v2 v2.2.4 Oct 3, 2019
@liggitt liggitt force-pushed the automated-cherry-pick-of-#83261-upstream-release-1.13-1570075716 branch from 8f12900 to a4e734a Compare October 3, 2019 05:00
@liggitt
Copy link
Member Author

liggitt commented Oct 3, 2019

/test pull-kubernetes-integration

@liggitt
Copy link
Member Author

liggitt commented Oct 3, 2019

/retest

@liggitt
Copy link
Member Author

liggitt commented Oct 3, 2019

cc @BenTheElder for kind failures (I'm not sure it's intended to be running against this branch)

@k8s-ci-robot
Copy link
Contributor

@liggitt: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind a4e734a link /test pull-kubernetes-e2e-kind
pull-kubernetes-e2e-gce-device-plugin-gpu a4e734a link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Member Author

liggitt commented Oct 3, 2019 •
edited

looks like the nvidia GPU tests are red on this release branch

@cblecker
Copy link
Member

cblecker commented Oct 3, 2019

/approve

@BenTheElder
Copy link
Member

It's not intended to be running but also shouldn't block.
I'll look at the job definition, IIRC we're skipping branches instead of selecting master, probably we don't skip 1.13...

@smarterclayton
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2019
@BenTheElder
Copy link
Member

sorry for the noise and thanks for the heads up, filed kubernetes/test-infra#14594 to skip all release branches.

@liggitt
Copy link
Member Author

liggitt commented Oct 3, 2019

/skip

@cjcullen
Copy link
Member

cjcullen commented Oct 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2019
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 4, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 17c28f0 into kubernetes:release-1.13 Oct 4, 2019
@raesene raesene mentioned this pull request Oct 4, 2019
Closed
@liggitt liggitt deleted the automated-cherry-pick-of-#83261-upstream-release-1.13-1570075716 branch October 4, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@caesarxuchao caesarxuchao

@cjcullen cjcullen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@liggitt @k8s-ci-robot @cblecker @BenTheElder @smarterclayton @cjcullen @tpepper @caesarxuchao