Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump klog to v0.3.2 #78465

Merged
merged 1 commit into from
May 30, 2019
Merged

Bump klog to v0.3.2 #78465

merged 1 commit into from
May 30, 2019

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented May 29, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes kubernetes/klog#53 #77904

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 29, 2019
@yuwenma
Copy link
Contributor Author

yuwenma commented May 29, 2019

/assign @dims

@k8s-ci-robot k8s-ci-robot requested review from caesarxuchao, cheftako and a team May 29, 2019 05:49
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 29, 2019
@yuwenma yuwenma mentioned this pull request May 29, 2019
Merged
@yuwenma
Copy link
Contributor Author

yuwenma commented May 29, 2019

/test pull-kubernetes-bazel-test

@xichengliudui
Copy link
Contributor

/kind cleanup
/priority backlog
/retest

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 29, 2019
@yuwenma
Copy link
Contributor Author

yuwenma commented May 29, 2019

/test pull-kubernetes-bazel-test
/test pull-kubernetes-dependencies

@BenTheElder
Copy link
Member

changes: kubernetes/klog@v0.3.1...v0.3.2

@BenTheElder
Copy link
Member

These failures look like actual problems with the tests:

INFO: From Testing //staging/src/k8s.io/apimachinery/pkg/util/runtime:go_default_test:
==================== Test output for //staging/src/k8s.io/apimachinery/pkg/util/runtime:go_default_test:
--- FAIL: TestHandleCrashLog (0.00s)
runtime_test.go:99: panic log should have 1 line of message, 1 line per goroutine and 2 lines per function call
FAIL
================================================================================
==================== Test output for //staging/src/k8s.io/apimachinery/pkg/util/runtime:go_default_test:
--- FAIL: TestHandleCrashLog (0.00s)
runtime_test.go:99: panic log should have 1 line of message, 1 line per goroutine and 2 lines per function call
FAIL
================================================================================
==================== Test output for //staging/src/k8s.io/apimachinery/pkg/util/runtime:go_default_test:
--- FAIL: TestHandleCrashLog (0.00s)
runtime_test.go:99: panic log should have 1 line of message, 1 line per goroutine and 2 lines per function call
FAIL
================================================================================

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/78465/pull-kubernetes-bazel-test/1133623934294429696

BenTheElder
BenTheElder reviewed May 29, 2019
View reviewed changes
Godeps/LICENSES Outdated Show resolved Hide resolved
@yuwenma yuwenma mentioned this pull request May 29, 2019
Closed
10 tasks
@yuwenma yuwenma force-pushed the bump-klog branch 3 times, most recently from a8112f6 to 741808b Compare May 29, 2019 21:04
@yuwenma
Copy link
Contributor Author

yuwenma commented May 29, 2019

/test pull-kubernetes-e2e-gce

@yuwenma
Copy link
Contributor Author

yuwenma commented May 30, 2019

/test pull-kubernetes-integration
/test pull-kubernetes-bazel-test

@yuwenma
Copy link
Contributor Author

yuwenma commented May 30, 2019

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented May 30, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit b094dd9 into kubernetes:master May 30, 2019
@krzysied krzysied mentioned this pull request Jun 12, 2019
Merged
@liggitt
Copy link
Member

liggitt commented Jun 12, 2019

reverted in #78931 due to performance regressions

This was referenced Jun 12, 2019
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@dims dims

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repeated trace in log file with error
6 participants
@yuwenma @xichengliudui @BenTheElder @liggitt @k8s-ci-robot @dims