Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase core master image from debian to distroless #75306

Closed
wants to merge 1 commit into from

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Mar 12, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This PR is part of the effort on rebasing kubernetes images to distroless/static. See this KEP for details.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 12, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @yuwenma. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 12, 2019
@k8s-ci-robot k8s-ci-robot requested review from ixdy and jbeda March 12, 2019 22:56
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2019
@yuwenma yuwenma changed the title [WIP] [waiting for b/127972250 to fix] rebase core master image from debian to distroless [WIP] Rebase core master image from debian to distroless Mar 23, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 2, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuwenma
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zmerlynn

If they are not already assigned, you can assign the PR to them by writing /assign @zmerlynn in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuwenma yuwenma changed the title [WIP] Rebase core master image from debian to distroless Rebase core master image from debian to distroless May 8, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2019
@yuwenma
Copy link
Contributor Author

yuwenma commented May 8, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 8, 2019
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2019
@justaugustus
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 20, 2019
@k8s-ci-robot
Copy link
Contributor

@yuwenma: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 19, 2020
@justaugustus
Copy link
Member

/remove-lifecycle rotten
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 19, 2020
@justaugustus
Copy link
Member

@yuwenma @liggitt -- What's the current status on this?
cc: @DirectXMan12 (ref: kubernetes/klog#70)

@dims
Copy link
Member

dims commented Apr 26, 2020

/hold

I don't see any evidence that distroless images support architectures other than amd64 (Please correct me if i am wrong!!!)

cc @tallclair

@BenTheElder
Copy link
Member

oof yeah, inspecting the images in cloud console shows only amd64 manifests (sampled a few).
GoogleContainerTools/distroless#406

@dims
Copy link
Member

dims commented Apr 27, 2020

@BenTheElder someone ported to arm arch as well https://github.com/discolix/discolix but that's it other arches don't work either

cc @tallclair

@dims
Copy link
Member

dims commented Apr 27, 2020

Looks like i missed a nuance, even if the manifest says amd64 like Ben observed, looks like the key here is :static
GoogleContainerTools/distroless#346

@BenTheElder
Copy link
Member

BenTheElder commented Apr 27, 2020 via email

@dims
Copy link
Member

dims commented Apr 27, 2020

/hold cancel

Right @BenTheElder

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2020
@dekkagaijin
Copy link
Contributor

Seems like distroless:static should be trivially multi-arch-friendly, though that obviously doesn't extend to :base and others with bundled libs and runtimes. I'll follow up to see how difficult it would be to push a manifest list to gcr.io/distroless/static:latest

@BenTheElder
Copy link
Member

BenTheElder commented Apr 27, 2020 via email

@dekkagaijin
Copy link
Contributor

@BenTheElder right, it'd require a manifest list to be pushed to the base image repo. amd64 is the default, otherwise.

@spiffxp
Copy link
Member

spiffxp commented Apr 29, 2020

needs rebase

@dims
Copy link
Member

dims commented Apr 29, 2020

Note that before we merge this PR - Revert "Revert "Revert "[Re-Apply][Distroless] Convert the GCE manifests for master containers.""" - needs to be Reverted again!

@dims
Copy link
Member

dims commented May 7, 2020

/close

Thanks a ton @yuwenma we are continuing this work in #90674

@k8s-ci-robot
Copy link
Contributor

@dims: Closed this PR.

In response to this:

/close

Thanks a ton @yuwenma we are continuing this work in #90674

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet