Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revendor k8s.io/utils and use diff+fields from there #74015

Closed
wants to merge 7 commits into from
Closed

Revendor k8s.io/utils and use diff+fields from there #74015

wants to merge 7 commits into from

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Feb 13, 2019 •
edited

Follow-up of kubernetes/utils#82

@k8s-ci-robot
Copy link
Contributor

@sttts: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/kubectl area/kubelet kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 13, 2019
@sttts
Copy link
Contributor Author

sttts commented Feb 13, 2019

/assign @thockin

thockin
thockin reviewed Feb 13, 2019
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I've been doing a ot of these reviews lately. I'd like to get a few more deps reviewers in the loop. Any objections? @cblecker @sttts and I are the only explicit ones listed.

staging/src/k8s.io/apimachinery/pkg/util/validation/field/path.go
index string // if name == "", this is a subscript (index or map key) of the previous element
parent *Path // nil if this is the root element
}
type Path = field.Path

// NewPath creates a root Path object.
func NewPath(name string, moreNames ...string) *Path {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why leave this shim in place? I know there are a lot of callers of this, but it seems like something gorename (or sed) could fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This affects bascially all 3rdparty API developers. You see it in our code with a hundred uses or so.

@logicalhan
Copy link
Member

/assign @cheftako

@k8s-ci-robot
Copy link
Contributor

@sttts: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sttts
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: thockin

If they are not already assigned, you can assign the PR to them by writing /assign @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kubeadm area/release-eng Issues or PRs related to the Release Engineering subproject sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 15, 2019
@k8s-ci-robot
Copy link
Contributor

@sttts: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-build e9e0661017edb2b05ca531ab5ee18b546ba8b372 link /test pull-kubernetes-bazel-build
pull-publishing-bot-validate e9e0661017edb2b05ca531ab5ee18b546ba8b372 link /test pull-publishing-bot-validate
pull-kubernetes-godeps e9e0661017edb2b05ca531ab5ee18b546ba8b372 link /test pull-kubernetes-godeps
pull-kubernetes-e2e-gce-device-plugin-gpu e9e0661017edb2b05ca531ab5ee18b546ba8b372 link /test pull-kubernetes-e2e-gce-device-plugin-gpu
pull-kubernetes-node-e2e e9e0661017edb2b05ca531ab5ee18b546ba8b372 link /test pull-kubernetes-node-e2e
pull-kubernetes-e2e-gce-100-performance e9e0661017edb2b05ca531ab5ee18b546ba8b372 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-typecheck e9e0661017edb2b05ca531ab5ee18b546ba8b372 link /test pull-kubernetes-typecheck
pull-kubernetes-e2e-gce e9e0661017edb2b05ca531ab5ee18b546ba8b372 link /test pull-kubernetes-e2e-gce
pull-kubernetes-local-e2e-containerized e9e0661017edb2b05ca531ab5ee18b546ba8b372 link /test pull-kubernetes-local-e2e-containerized
pull-kubernetes-verify e9e0661017edb2b05ca531ab5ee18b546ba8b372 link /test pull-kubernetes-verify
pull-kubernetes-kubemark-e2e-gce-big e9e0661017edb2b05ca531ab5ee18b546ba8b372 link /test pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-bazel-test e9e0661017edb2b05ca531ab5ee18b546ba8b372 link /test pull-kubernetes-bazel-test
pull-kubernetes-integration e9e0661017edb2b05ca531ab5ee18b546ba8b372 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts sttts removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2019
@liggitt liggitt removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 21, 2019
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 21, 2019
@k8s-ci-robot
Copy link
Contributor

@sttts: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt liggitt removed sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Mar 6, 2019
@justaugustus justaugustus added this to Backlog in SIG Release Apr 28, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2019
@thockin thockin removed their assignment Jun 28, 2019
@sttts sttts closed this Jul 9, 2019
SIG Release automation moved this from Backlog to Done Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@apelisse apelisse Awaiting requested review from apelisse

@awly awly Awaiting requested review from awly

Assignees

@cheftako cheftako

Labels
area/apiserver area/kubeadm area/kubectl area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sttts @k8s-ci-robot @logicalhan @fejta-bot @thockin @cheftako @liggitt