Revert "Merge pull request #35821 from vishh/gci-mounter-scope" #36206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saad-ali
added
the
priority/critical-urgent
k8s-github-robot
added
kind/api-change
|
All checks are green: Manually merging to unblock submit queue. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Nov 9, 2016
Automatic merge from submit-queue Make GCI nodes mount non tmpfs, ext* & bind mounts using an external mounter This PR downloads the stage1 & gci-mounter ACIs as part of cluster bring up instead of downloading them dynamically from gcr.io, which was the cause for #36206. I have also optimized the containerized mounter to pre-load the mounter image once to avoid fetch latency while using it. Original PR which got reverted: #35821 ```release-note GCI nodes use an external mounter script to mount NFS & GlusterFS storage volumes ``` @mtaufen Node e2e is not re-enabled in this PR. cc @jingxu97
dims
pushed a commit
to dims/kubernetes
that referenced
this pull request
Feb 8, 2018
Revert "Merge pull request kubernetes#35821 from vishh/gci-mounter-scope"
dims
pushed a commit
to dims/kubernetes
that referenced
this pull request
Feb 8, 2018
Automatic merge from submit-queue Make GCI nodes mount non tmpfs, ext* & bind mounts using an external mounter This PR downloads the stage1 & gci-mounter ACIs as part of cluster bring up instead of downloading them dynamically from gcr.io, which was the cause for kubernetes#36206. I have also optimized the containerized mounter to pre-load the mounter image once to avoid fetch latency while using it. Original PR which got reverted: kubernetes#35821 ```release-note GCI nodes use an external mounter script to mount NFS & GlusterFS storage volumes ``` @mtaufen Node e2e is not re-enabled in this PR. cc @jingxu97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts PR #35821. That PR caused lots of different tests suites to randomly flake with
Detected 6 ready nodes, found 6 nodes out of expected 7. Your cluster may not be fully functional.See #34665 (comment)
CC @vishh @jingxu97 @mtaufen @bprashanth
This change is