Kubedns logging #36013
Merged
Kubedns logging #36013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/XL
|
Jenkins verification failed for commit 39e5d426c3d01344c221fa97e9eb409cb92a52f0. Full PR test history. The magic incantation to run this job again is |
bowei
force-pushed
the
kubedns-logging
branch
from
39e5d42
to
b15344c
Compare
|
I took a quick look. Assigned to @MrHohn. Can you post a snippet of logs here? |
thockin
added
release-note-none
v(2)v(3)v(4) |
MrHohn
reviewed
Nov 3, 2016
| server.SetDefaults(skydnsConfig) | ||
| s := server.New(d.kd, skydnsConfig) | ||
| if err := metrics.Metrics(); err != nil { | ||
| glog.Fatalf("skydns: %s", err) | ||
| glog.Fatalf("Skydns metrics error: %s", err) | ||
| } else if metrics.Port != "" { |
There was a problem hiding this comment.
Do we need to give a warning if metrics.Port is not set?
| @@ -230,7 +243,9 @@ func assertIsService(obj interface{}) (*kapi.Service, bool) { | |||
|
|
|||
| func (kd *KubeDNS) newService(obj interface{}) { | |||
| if service, ok := assertIsService(obj); ok { | |||
| glog.V(4).Infof("Add/Updated for service %v", service.Name) | |||
| glog.V(2).Infof("newService %v", service.Name) | |||
| @@ -63,7 +63,8 @@ func ReverseArray(arr []string) []string { | |||
| func GetSkyMsg(ip string, port int) (*msg.Service, string) { | |||
| msg := NewServiceRecord(ip, port) | |||
| hash := HashServiceRecord(msg) | |||
| glog.V(2).Infof("DNS Record:%s, hash:%s", fmt.Sprintf("%v", msg), hash) | |||
| glog.V(5).Infof("Created new DNS record: %s, hash:%s", | |||
There was a problem hiding this comment.
I think this function construct a new record but not actually create one?
| "github.com/skynetservices/skydns/msg" | ||
| ) | ||
|
|
||
| func TestTreeCache(t *testing.T) { |
There was a problem hiding this comment.
Should we also test SetSubCache() here?
Saw the TODO says we should combine it with SetEntry() in future. May be wait til then?
|
|
||
| retval := []skymsg.Service{} | ||
| for _, val := range records { | ||
| retval = append(retval, *val) | ||
| } | ||
|
|
||
| glog.V(2).Infof("records:%v, retval:%v, path:%v", records, retval, path) | ||
| glog.V(4).Infof("getRecordsForPath retval=%+v, path=%v", retval, path) |
There was a problem hiding this comment.
I guess it also make sense to make it identical to the function name as it is V4?
| @@ -676,34 +709,39 @@ func (kd *KubeDNS) getPodIP(path []string) (string, error) { | |||
| // We can add support for wildcard queries later, if needed. | |||
| func (kd *KubeDNS) isFederationQuery(path []string) bool { | |||
| if len(path) != 4+len(kd.domainPath) { | |||
| glog.V(2).Infof("not a federation query: len(%q) != 4+len(%q)", path, kd.domainPath) | |||
| glog.V(4).Infof("not a federation query: len(%q) != 4+len(%q)", path, kd.domainPath) | |||
| func TestTreeCache(t *testing.T) { | ||
| tc := NewTreeCache() | ||
|
|
||
| { |
| t.Error("should not affect p3.p1.") | ||
| } | ||
| if tc.DeletePath("p1", "p2") { | ||
| t.Fatal() |
There was a problem hiding this comment.
May be add a bit error message when fail?
| {"key3", []string{"p1", "p3"}}, | ||
| } { | ||
| if _, ok := tc.GetEntry(testCase.k, testCase.p...); ok { | ||
| t.Error() |
--v=2 is low noise (record changes), can be default --v=3 will shows per request logging Note: due to the code path with which we integrate with skydns, we don't see non-PILLAR_DOMAIN requests, so these will never be logged.
bowei
force-pushed
the
kubedns-logging
branch
from
b15344c
to
d9557d4
Compare
|
/lgtm |
k8s-github-robot
added
the
lgtm
|
Jenkins GCI GCE e2e failed for commit d9557d4. Full PR test history. The magic incantation to run this job again is |
|
gci gce e2e test this |
|
@k8s-bot gci gce e2e test this |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
#29053
may resolve #29054, but depends on what the specific ask is
This change is