Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up LocalTrafficDetector construction / tests #124582

Merged
merged 6 commits into from Apr 28, 2024
Merged

clean up LocalTrafficDetector construction / tests #124582

merged 6 commits into from Apr 28, 2024

Commits on Apr 27, 2024

  1. LocalTrafficDetector construction and test improvements

    @danwinship
    danwinship committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    ca051d9 View commit details
    Browse the repository at this point in the history

  2. Reorder getLocalDetector unit test fields so "input" args come before… 

    … "output" args
    @danwinship
    danwinship committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    58831f2 View commit details
    Browse the repository at this point in the history

  3. Don't pass DetectLocalMode as a separate arg to getLocalDetector 

    It's already part of `config`
    @danwinship
    danwinship committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    7b50330 View commit details
    Browse the repository at this point in the history

  4. Clarify test names in preparation for merging

    @danwinship
    danwinship committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    a5163e4 View commit details
    Browse the repository at this point in the history

  5. Merge single-stack/dual-stack LocalTrafficDetector construction 

    Also, only warn if the *primary* IP family is not correctly configured
(since we don't actually know if the cluster is really dual-stack or
not), and pass the pair of detectors to the proxiers as a map rather
than an array.
    @danwinship
    danwinship committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    6089c39 View commit details
    Browse the repository at this point in the history

  6. Remove the rest of Test_getDualStackLocalDetectorTuple

    @danwinship
    danwinship committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    e782bd8 View commit details
    Browse the repository at this point in the history