New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for policy secondary authz runtime cost limit. #124569
base: master
Are you sure you want to change the base?
Add integration tests for policy secondary authz runtime cost limit. #124569
Conversation
We intentionally gave secondary authorization a high runtime cost. Only two checks per expression and 28 per policy should be allowed if that cost is being counted.
Skipping CI for Draft Pull Request. |
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@benluddy: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/triage accepted |
We intentionally gave secondary authorization a high runtime cost. Only two checks per expression and 28 per policy should be allowed if that cost is being counted.
What type of PR is this?
/kind cleanup
/sig api-machinery
What this PR does / why we need it:
Adds integration tests demonstrating that we have wired up the cost calculations for the our CEL library functions and that the runtime cost budgets are being enforced.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: