WIP: Allow to build with go 1.21 #124169
WIP: Allow to build with go 1.21 #124169
Conversation
The glibc bug used by go 1.22 is breaking runc 1.2.0 in some cases. This does not directly influence Kubernetes, but downstream may rely on Kubernetes as well as runc in their build environments. This means that forcing users to build Kubernetes with go 1.22 may break their build toolchain, which is especially the case for container runtimes. We now relax that restriction to allow building with go 1.21 until the runc issue has been resolved. Refers to: opencontainers/runc#4233 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
k8s-ci-robot
added
release-note
|
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Apr 3 02:18:49 UTC 2024. |
k8s-ci-robot
added
cncf-cla: yes
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-priority
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
area/dependency
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| module k8s.io/kubernetes | |||
|
|
|||
| go 1.22.0 | |||
| go 1.21 | |||
There was a problem hiding this comment.
-1 on this... the go version used to build kubernetes doesn't impact the go version used to build the runc binary
We want to stay on latest go in latest kube releases (in this case, the loop var behavior and go workspaces are things we care about using go 1.22 with)
There was a problem hiding this comment.
It also requires more changes through the codebase as it seems.
There was a problem hiding this comment.
Yeah, the runc refusal to build with go1.22 looks self-inflicted, and limited to the nsenter package which kubernetes does not vendor / build / link.
liggitt
removed
the
kind/regression
k8s-ci-robot
added
the
do-not-merge/needs-kind
|
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing this, I think it's not the right solution. |
What type of PR is this?
/kind regression
What this PR does / why we need it:
The glibc bug used by go 1.22 is breaking runc 1.2.0 in some cases. This does not directly influence Kubernetes, but downstream may rely on Kubernetes as well as runc in their build environments. This means that forcing users to build Kubernetes with go 1.22 may break their build toolchain, which is especially the case for container runtimes. We now relax that restriction to allow building with go 1.21 until the runc issue has been resolved.
Which issue(s) this PR fixes:
Refers to: opencontainers/runc#4233, #124168
Special notes for your reviewer:
cc @kubernetes/sig-architecture @kubernetes/sig-release
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: