Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self nominate ffromani to be a sig-node reviewer #123757

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Mar 6, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

self nominate @ffromani to be a sig-node reviewer

Which issue(s) this PR fixes:

Fixes #N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Per https://github.com/kubernetes/community/blob/master/sig-node/sig-node-contributor-ladder.md#reviewer

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 6, 2024
@ffromani
Copy link
Contributor Author

ffromani commented Mar 6, 2024

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 6, 2024
@swatisehgal
Copy link
Contributor

Huge +1 (non-binding)

@ffromani
Copy link
Contributor Author

ffromani commented Mar 6, 2024

/test pull-kubernetes-e2e-kind

@kannon92
Copy link
Contributor

kannon92 commented Mar 7, 2024

+1!

1 similar comment
@pacoxu
Copy link
Member

pacoxu commented Mar 7, 2024

+1!

@pacoxu
Copy link
Member

pacoxu commented Mar 7, 2024

/cc @kubernetes/sig-node-leads

@k8s-ci-robot
Copy link
Contributor

@pacoxu: GitHub didn't allow me to request PR reviews from the following users: kubernetes/sig-node-leads.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kubernetes/sig-node-leads

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I totally support this self-nomination.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 428a25875d9ca8931fdbf5ed0f623bc7f36ef50f

@dchen1107
Copy link
Member

/lgtm
/approve

Thanks @ffromani for your contribution.

@ffromani
Copy link
Contributor Author

ffromani commented Mar 9, 2024

/assign @thockin

per bot suggestion

@thockin
Copy link
Member

thockin commented Mar 10, 2024

Thanks and congrats!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, ffromani, SergeyKanzhelev, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2024
@aojea
Copy link
Member

aojea commented Mar 10, 2024

+1

@bart0sh
Copy link
Contributor

bart0sh commented Mar 13, 2024

/triage accepted
+1

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 13, 2024
@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Mar 13, 2024
@ffromani
Copy link
Contributor Author

ffromani commented Apr 2, 2024

Thanks everyone for the +1s! Appreciate it a lot!

does this PR need to be added to a milestone? I don't mind waiting for the 1.31 cycle to start, but wondering if when the 1.31 cycle start we'd need the milestone-1.31 to be added here.

@pacoxu
Copy link
Member

pacoxu commented Apr 3, 2024

Release of v1.30 is schedule on April 17th.
/milestone v1.31

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 3, 2024
@bart0sh
Copy link
Contributor

bart0sh commented Apr 3, 2024

/assign @mrunalp @derekwaynecarr @dchen1107
for an approval

@k8s-ci-robot k8s-ci-robot merged commit 99735cc into kubernetes:master Apr 18, 2024
14 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Apr 18, 2024
@ffromani ffromani deleted the ffromani-sig-node-reviewer branch April 18, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

Successfully merging this pull request may close these issues.

None yet