promote contextual logging to beta, enabled by default #122589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in kubernetes/enhancements#4219 (comment) benchstat reports no significant difference in most test cases for scheduler_perf for -v3. At -v5, there is some slowdown, but that is justified because the output becomes more useful for debugging. Enabling the feature by default ensures that log output becomes better regardless whether users know and remember to enable it.
k8s-ci-robot
added
release-note
|
/retest "Pod got deleted unexpectedly" and #108891 |
12 tasks
|
/sig instrumentation |
k8s-ci-robot
added
sig/instrumentation
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
|
/priority important-soon Code freeze for 1.30 is approaching... |
k8s-ci-robot
added
the
priority/important-soon
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 08b2a514745b7b14822e29cb301eebfdbbdd3b2f
|
|
/label api-review Because this touches |
k8s-ci-robot
added
the
api-review
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, logicalhan, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Enabling the feature by default ensures that log output becomes better regardless whether users know and remember to enable it.
Which issue(s) this PR fixes:
Related-to kubernetes/enhancements#3077
Special notes for your reviewer:
As discussed in
kubernetes/enhancements#4219 (comment) benchstat reports no significant difference in most test cases for scheduler_perf for -v3. At -v5, there is some slowdown, but that is justified because the output becomes more useful for debugging.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: