Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self nominate Kevin Hannon for reviewer for job controller #121782

Merged
merged 1 commit into from Nov 13, 2023
Merged

Self nominate Kevin Hannon for reviewer for job controller #121782

merged 1 commit into from Nov 13, 2023

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Nov 7, 2023 •
edited

I have lead the PodReplacementPolicy KEP for alpha and I helped review/fix some issues in beta.

https://github.com/kubernetes/kubernetes/pulls?q=+is%3Apr+reviewed-by%3Akannon92+label%3Asig%2Fapps+

I have also been an active reviewer and helped GA job tracking last release. I hope to continue reviewing Job related code.

What type of PR is this?

What this PR does / why we need it:

Add kannon92 as a reviewer for the job controller code.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@kannon92
Self nominate Kevin Hannon for reviewer for job controller
2645b22 
I have been lead the PodReplacementPolicy KEP for alpha and I helped review/fix some issues in beta.  

https://github.com/kubernetes/kubernetes/pulls?q=+is%3Apr+reviewed-by%3Akannon92+label%3Asig%2Fapps+

I have also been an active reviewer and helped GA job tracking last release.  I hope to continue reviewing Job related code.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 7, 2023
@kannon92
Copy link
Contributor Author

kannon92 commented Nov 7, 2023

/kind feature

?

@kannon92
Copy link
Contributor Author

kannon92 commented Nov 7, 2023

/retest

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 7, 2023
@kannon92
Copy link
Contributor Author

kannon92 commented Nov 7, 2023

/retest

@kannon92
Copy link
Contributor Author

kannon92 commented Nov 7, 2023

/cc @alculquicondor @mimowo

@mimowo
Copy link
Contributor

mimowo commented Nov 8, 2023

SGTM, could you please convert the reviewer requirements as a checkbox list here.

@mimowo
Copy link
Contributor

mimowo commented Nov 9, 2023

/remove-kind feature
/kind documentation

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Nov 9, 2023
@mimowo
Copy link
Contributor

mimowo commented Nov 9, 2023

+1 for the nomination

@alculquicondor
Copy link
Member

+1, although you need a sponsor from a different company :)

Thank you for your invaluable contributions!

@dims
Copy link
Member

dims commented Nov 10, 2023

i am happy to sponsor! +1 from me.

@alculquicondor
Copy link
Member

/approve
:D

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
@kannon92
Copy link
Contributor Author

@dims do you want to give this a milestone 1.29 since its not a code change?

@dims
Copy link
Member

dims commented Nov 13, 2023

/approve
/lgtm
/milestone v1.29

(this is just editing an OWNERS file, so we should be safe and not subject to code freeze)

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 13, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5145d9901400bdc214420a62a9233c6d520535c9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, dims, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kannon92
Copy link
Contributor Author

kannon92 commented Nov 13, 2023 •
edited

Thank you @alculquicondor, @mimowo and @dims !

@kannon92
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5dc9453 into kubernetes:master Nov 13, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiratree atiratree Awaiting requested review from atiratree

@kow3ns kow3ns Awaiting requested review from kow3ns

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Apps
Archived in project
[sig-release] Bug Triage
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kannon92 @k8s-ci-robot @mimowo @alculquicondor @dims