Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-scheduler: convert the remaining part to use contextual logging #120933

Merged
merged 3 commits into from
Oct 27, 2023
Merged

kube-scheduler: convert the remaining part to use contextual logging #120933

merged 3 commits into from
Oct 27, 2023

Conversation

mengjiao-liu
Copy link
Member

@mengjiao-liu mengjiao-liu commented Sep 29, 2023 •
edited

What type of PR is this?

/kind feature
/kind cleanup

What this PR does / why we need it:

Other parts of the kube-scheduler have been merged, see #91633 (comment)

This PR will modify the following:

Which issue(s) this PR fixes:

Part of #91633 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Migrated the remainder of the scheduler to use [contextual logging](https://k8s.io/docs/concepts/cluster-administration/system-logs/#contextual-logging).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3077-contextual-logging

/sig instrumentation
/wg structured-logging
/area logging
/sig scheduling

Wait for #116885 to merge.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 29, 2023
@mengjiao-liu mengjiao-liu mentioned this pull request Sep 29, 2023
Open
@mengjiao-liu
Copy link
Member Author

The work will continue after the two-week holiday.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2023
@hwdef
Copy link
Member

hwdef commented Oct 7, 2023

/lgtm for hack

@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-scheduler-remaining-part branch from aaf8bf6 to 04bd6fe Compare October 11, 2023 09:40
@mengjiao-liu
Copy link
Member Author

/test all

1 similar comment
@mengjiao-liu
Copy link
Member Author

/test all

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 11, 2023
@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-scheduler-remaining-part branch from e488a90 to dd982f6 Compare October 12, 2023 10:24
@mengjiao-liu
Copy link
Member Author

/test all

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2023
@mengjiao-liu mengjiao-liu marked this pull request as ready for review October 13, 2023 02:38
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-scheduler-remaining-part branch from dd982f6 to cca3721 Compare October 24, 2023 09:40
@mengjiao-liu
Copy link
Member Author

Rebased.

@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-scheduler-remaining-part branch from cca3721 to 2cea512 Compare October 24, 2023 09:57
@dims dims added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 24, 2023
@dims
Copy link
Member

dims commented Oct 25, 2023

removed needs-rebase label by hand, automation did not clear it!

@dims dims removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 25, 2023
@kerthcet
Copy link
Member

/lgtm
/approve
/remove-kind feature as cleanup only.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 26, 2023
@k8s-ci-robot
Copy link
Contributor

@kerthcet: Those labels are not set on the issue: kind/, kind/as, kind/only.

In response to this:

/lgtm
/approve
/remove-kind feature as cleanup only.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Oct 26, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4d9564fb3658ebebdd855ae442c58f7bd65d6f15

@kerthcet
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 26, 2023
@mengjiao-liu
Copy link
Member Author

@pohly for approval

@pohly
Copy link
Contributor

pohly commented Oct 27, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kerthcet, mengjiao-liu, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit fd5c406 into kubernetes:master Oct 27, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly left review comments

@kerthcet kerthcet kerthcet left review comments

@denkensk denkensk Awaiting requested review from denkensk

@hwdef hwdef Awaiting requested review from hwdef

Assignees

@pohly pohly

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mengjiao-liu @k8s-ci-robot @hwdef @dashpole @dims @kerthcet @pohly