New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not touch swap for cgroup v1 if not available #119486
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Should this not be checked regardless of whether unified mode is enabled. Otherwise we explicitly set
memory.swap.max
even if swap is disabled?For reference, I am having issues launching a >= 1.28.0 using
kind
on a node where swap is disabled. (I will spend some time creating an issue tomorrow).cc @iholder101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this fix a problem? I cannot catch up with you here.
This added a check for
no-cgroup v2
: to not set swap if swap controller is not available.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this fix is fine. I was asking whether this check should also be done on
cgroup v2
systems. I have a PR #120784 under review to do this -- effectively moving the check higher up the call chain.Feel free to review this as well.