Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement QueueingHintFn in VolumeRestriction #119405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement QueueingHintFn in VolumeRestriction #119405

wants to merge 1 commit into from

Conversation

HirazawaUi
Copy link
Contributor

@HirazawaUi HirazawaUi commented Jul 18, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #118893

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-scheduler implements scheduling hints for the VolumeRestriction plugin.
The scheduling hints allow the scheduler to only retry scheduling a Pod 
that was previously rejected by the VolumeRestriction plugin in three situations.
a. A new node added.
b. A pod delete, and the deleted pod conflicts with the current pod has readWriteOncePodPVCs.
c. A new pvc added, and the pvc belongs to pod.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @HirazawaUi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 18, 2023
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 18, 2023
@charles-chenzz
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2023
@HirazawaUi
Copy link
Contributor Author

/retest

AxeZhan
AxeZhan reviewed Jul 19, 2023
View reviewed changes
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
@HirazawaUi HirazawaUi force-pushed the implement-queueinghintfn-volume-restriction branch from cc417a3 to bb4c899 Compare July 19, 2023 10:31
@HirazawaUi
Copy link
Contributor Author

@AxeZhan thanks for review, I've made changes to the suggest

@HirazawaUi
Copy link
Contributor Author

/retest

2 similar comments
@HirazawaUi
Copy link
Contributor Author

/retest

@HirazawaUi
Copy link
Contributor Author

/retest

@HirazawaUi HirazawaUi force-pushed the implement-queueinghintfn-volume-restriction branch 2 times, most recently from 187283c to 8da238a Compare July 23, 2023 13:10
@HirazawaUi
Copy link
Contributor Author

/retest

@sanposhiho
Copy link
Member

@AxeZhan Can you take the first reviewer on this? Then I'll go through after your /lgtm.

@HirazawaUi HirazawaUi force-pushed the implement-queueinghintfn-volume-restriction branch from 156f844 to 6e7f6f7 Compare October 29, 2023 06:58
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2023
@HirazawaUi
Copy link
Contributor Author

I have rebased and replaced QueueAfterBackoff with Queue.

@HirazawaUi HirazawaUi force-pushed the implement-queueinghintfn-volume-restriction branch 3 times, most recently from 34710b0 to f2063d1 Compare October 31, 2023 14:08
sanposhiho
sanposhiho reviewed Nov 19, 2023
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back from Kubecon + post-Kubecon days with tons of tasks made during Kubecon. 😩

pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go Show resolved Hide resolved
@HirazawaUi HirazawaUi force-pushed the implement-queueinghintfn-volume-restriction branch 2 times, most recently from d0ce032 to a189004 Compare November 19, 2023 18:07
@HirazawaUi
Copy link
Contributor Author

/retest

@sanposhiho sanposhiho mentioned this pull request Nov 23, 2023
Merged
@HirazawaUi HirazawaUi force-pushed the implement-queueinghintfn-volume-restriction branch from a189004 to 6b76cfb Compare November 26, 2023 13:12
@HirazawaUi HirazawaUi force-pushed the implement-queueinghintfn-volume-restriction branch from 6b76cfb to 701046a Compare December 1, 2023 16:53
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 1, 2023
@HirazawaUi HirazawaUi force-pushed the implement-queueinghintfn-volume-restriction branch from 701046a to 107ed2d Compare December 2, 2023 16:30
@HirazawaUi HirazawaUi force-pushed the implement-queueinghintfn-volume-restriction branch from 107ed2d to 1e3fca7 Compare December 4, 2023 17:09
@sanposhiho sanposhiho mentioned this pull request Dec 5, 2023
Open
12 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 3, 2024
@sanposhiho
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory carlory left review comments

@sanposhiho sanposhiho sanposhiho left review comments

@AxeZhan AxeZhan AxeZhan left review comments

@chendave chendave Awaiting requested review from chendave

Assignees

@sanposhiho sanposhiho

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Scheduling
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@HirazawaUi @k8s-ci-robot @charles-chenzz @sanposhiho @AxeZhan @k8s-triage-robot @carlory