New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#118135 replace gogo/protobuf and golang/protobuf with google #118140
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Welcome @ohDaddyPlease! |
Hi @ohDaddyPlease. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ohDaddyPlease The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/remove-sig api-machinery |
/sig api-machinery |
overall, removing the dependency on gogo protobuf is waaaay more involved, see:
|
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Replace deprecated gogo/golang protobuf with google protobuf
Which issue(s) this PR fixes:
#118135
Special notes for your reviewer:
I think we can do replacing without problem. All tests passed.