Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove GAed KubeletCredentialProviders （1.28） #116901

Merged
merged 2 commits into from
May 8, 2023
Merged

remove GAed KubeletCredentialProviders （1.28） #116901

merged 2 commits into from
May 8, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Mar 24, 2023 •
edited

/kind cleanup

Fixes kubernetes/enhancements#2133

Special notes for your reviewer:

Does this PR introduce a user-facing change?

remove GAed feature gate KubeletCredentialProviders

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.27 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.27.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Mar 23 22:22:11 UTC 2023.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 24, 2023
@pacoxu pacoxu changed the title remove GAed KubeletCredentialProviders [WIP]remove GAed KubeletCredentialProviders Mar 24, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2023
pacoxu
pacoxu commented Mar 24, 2023
View reviewed changes
test/e2e_node/image_credential_provider.go
@@ -30,7 +30,7 @@ import (
admissionapi "k8s.io/pod-security-admission/api"
)

var _ = SIGDescribe("ImageCredentialProvider [Feature:KubeletCredentialProviders]", func() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fg is GAed in v1.26. Should we remove the feature tag in e2e node test? But there are some test ci for this and we should not change it now in my mind.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected to work in all clusters? Feature also implies tests that are not portable. This test is known to be problematic for other reasons but I'm not sure re: portability

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#117527 will add the feature tag back.

Sorry for the mistake.

@pacoxu pacoxu force-pushed the cleanup-KubeletCredentialProviders branch from cf5a20e to f9a5502 Compare March 24, 2023 02:52
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Mar 29, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Mar 30, 2023

/retest
after kubernetes/test-infra#29126 is merged

@pacoxu pacoxu changed the title [WIP]remove GAed KubeletCredentialProviders remove GAed KubeletCredentialProviders （1.28） Mar 30, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Mar 30, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Mar 30, 2023

/triage accepted
/priority important-longterm
/assign @SergeyKanzhelev

@pacoxu
Copy link
Member Author

pacoxu commented May 8, 2023

@pacoxu let's fix the test-infra references as well ( https://cs.k8s.io/?q=KubeletCredentialProviders&i=nope&files=&excludeFiles=&repos=kubernetes/kubernetes,kubernetes/test-infra ) and i can land both PRs simultaneously

I think we can remove those test that focus on KubeletCredentialProviders as this is GAed. I removed the [Feature:KubeletCredentialProviders] from the test below.

https://github.com/pacoxu/kubernetes/blob/27cdddeaf16717d0115d9445128520a0db85c245/test/e2e_node/image_credential_provider.go#L33-L36

@k8s-ci-robot
Copy link
Contributor

@pacoxu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-kubelet-credential-provider 27cddde link false /test pull-kubernetes-e2e-gce-kubelet-credential-provider

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacoxu pacoxu mentioned this pull request May 8, 2023
Merged
@pacoxu
Copy link
Member Author

pacoxu commented May 8, 2023

/test pull-kubernetes-e2e-gce-kubelet-credential-provider

I removed it in kubernetes/test-infra#29454

@dims
Copy link
Member

dims commented May 8, 2023

/skip
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2023
@aojea aojea mentioned this pull request May 8, 2023
Merged
@dims
Copy link
Member

dims commented May 8, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 55f46476aa3b83b67a4742b77fe2f19a9722018d

@k8s-ci-robot k8s-ci-robot merged commit dd43d86 into kubernetes:master May 8, 2023
16 checks passed
SIG Node CI/Test Board automation moved this from Archive-it to Done May 8, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done May 8, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 8, 2023
@SataQiu SataQiu mentioned this pull request Jun 9, 2023
Merged
@aojea aojea mentioned this pull request Aug 18, 2023
Merged
lzhecheng added a commit to lzhecheng/cloud-provider-azure that referenced this pull request Aug 23, 2023
@lzhecheng
Remove KubeletCredentialProviders feature gate in template
94d63c7 
Since k8s 1.28, this feature gate has been removed.
kubernetes/kubernetes#116901

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@lzhecheng lzhecheng mentioned this pull request Aug 23, 2023
Merged
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/cloud-provider-azure that referenced this pull request Oct 10, 2023
@lzhecheng
Remove KubeletCredentialProviders feature gate in template Since k8s …
ac7f488 
…1.28, this feature gate has been removed. kubernetes/kubernetes#116901

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/cloud-provider-azure that referenced this pull request Oct 10, 2023
@lzhecheng
Remove KubeletCredentialProviders feature gate in template Since k8s …
d892974 
…1.28, this feature gate has been removed. kubernetes/kubernetes#116901

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/cloud-provider-azure that referenced this pull request Oct 10, 2023
@lzhecheng
Remove KubeletCredentialProviders feature gate in template Since k8s …
6bbe148 
…1.28, this feature gate has been removed. kubernetes/kubernetes#116901

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/cloud-provider-azure that referenced this pull request Oct 10, 2023
@lzhecheng
Remove KubeletCredentialProviders feature gate in template Since k8s …
b9befc9 
…1.28, this feature gate has been removed. kubernetes/kubernetes#116901

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@damonmaria damonmaria mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@ndixita ndixita Awaiting requested review from ndixita

@ibabou ibabou Awaiting requested review from ibabou

@mtaufen mtaufen Awaiting requested review from mtaufen

@adisky adisky Awaiting requested review from adisky

@bart0sh bart0sh Awaiting requested review from bart0sh

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dims dims Awaiting requested review from dims

@mrunalp mrunalp Awaiting requested review from mrunalp

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@dims dims

@mrunalp mrunalp

@derekwaynecarr derekwaynecarr

@adisky adisky

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

Kubelet Credential Provider