Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update otelhttp dependency to v0.35.1 #116140

Merged
merged 1 commit into from Feb 28, 2023
Merged

Update otelhttp dependency to v0.35.1 #116140

merged 1 commit into from Feb 28, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Feb 28, 2023 •
edited

What type of PR is this?

/kind bug
/sig instrumentation

What this PR does / why we need it:

Update the otelhttp dependency to include open-telemetry/opentelemetry-go-contrib#2983. That patch is necessary to prevent port-forwarding from breaking when using APIServerTracing.

Which issue(s) this PR fixes:

Fixes #116139

This is part of the beta milestone for kubernetes/enhancements#647

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/647-apiserver-tracing/README.md

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 28, 2023
@dashpole
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 28, 2023
@dashpole
Copy link
Contributor Author

cc @kubernetes/sig-instrumentation-leads

@dashpole dashpole mentioned this pull request Feb 28, 2023
Merged
8 tasks
@liggitt
Copy link
Member

liggitt commented Feb 28, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e4bffac1f84ee4dbab017976cb40ba4f827f3cbe

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@cici37
Copy link
Contributor

cici37 commented Feb 28, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit f22060c into kubernetes:master Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 28, 2023
@dashpole dashpole deleted the fix_nobody_tracing branch March 4, 2023 16:26
k8s-ci-robot added a commit that referenced this pull request Sep 7, 2023
@k8s-ci-robot
Merge pull request #116143 from dashpole/otelhttp_26
a1ae926 
cherry pick of #116140: update otelhttp to v0.35.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

Enabling APIServer tracing breaks port forwarding
4 participants
@dashpole @liggitt @k8s-ci-robot @cici37