Remove/Withdraw NetworkPolicy Status

[rikatz]

What type of PR is this?

/kind cleanup
/kind feature
/kind deprecation

What this PR does / why we need it:

sig-network has decided to not move forward with NetworkPolicyStatus feature. This PR removes the feature implemented in #107963

Which issue(s) this PR fixes:

Fixes kubernetes/enhancements#2943

Special notes for your reviewer:

I've added the comment with the previous protobuf name, lmk if this is fine :)

Does this PR introduce a user-facing change?

Remove withdrawn feature NetworkPolicyStatus

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP](https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/2943-networkpolicy-status)

[rikatz]

/sig network

[k8s-triage-robot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[sftim]

For the changelog, do we actually mean:

Changed NetworkPolicy to always have an empty `.status` field

or something similar? Maybe we'd also mention that the feature gate is now deprecated and doesn't work, and that NetworkPolicies never have a status subresource.

[cici37]

/remove-sig api-machinery

[liggitt]

I don't think the "after_roundtrip" files are supposed to be checked in. @liggitt is that right?

They should persist when we're intentionally removing the ability to round trip all data known to previously released types, like we are here. The after_roundtrip files make visible the fact that current type definitions drop (or alter!!!) data which type definitions in previous releases serialized. They should be ~rare, and really only occur when we knowingly intentionally drop fields.

The diff shows the only thing getting dropped is the status stanza which we never allowed to persist in etcd because of the alpha feature:

diff -u \
   <(tail -c +5 networking.k8s.io.v1.NetworkPolicy.pb | protoc --decode_raw) \
   <(tail -c +5 networking.k8s.io.v1.NetworkPolicy.after_roundtrip.pb | protoc --decode_raw)

--- /dev/fd/63	2023-05-01 19:46:54
+++ /dev/fd/62	2023-05-01 19:46:54
@@ -144,23 +144,6 @@
     }
     4: "policyTypesValue"
   }
-  3 {
-    1 {
-      1: "typeValue"
-      2 {
-        14 {
-        }
-        12: 0x65756c6156737574
-      }
-      3: 3
-      4 {
-        1: 1072918861
-        2: 0
-      }
-      5: "reasonValue"
-      6: "messageValue"
-    }
-  }
 }
 3: ""
 4: ""

diff networking.k8s.io.v1.NetworkPolicy{,.after_roundtrip}.yaml

98,105d97
< status:
<   conditions:
<   - lastTransitionTime: "2004-01-01T01:01:01Z"
<     message: messageValue
<     observedGeneration: 3
<     reason: reasonValue
<     status: statusValue
<     type: typeValue

diff networking.k8s.io.v1.NetworkPolicy{,.after_roundtrip}.json

162,173d161
<   },
<   "status": {
<     "conditions": [
<       {
<         "type": "typeValue",
<         "status": "statusValue",
<         "observedGeneration": 3,
<         "lastTransitionTime": "2004-01-01T01:01:01Z",
<         "reason": "reasonValue",
<         "message": "messageValue"
<       }
<     ]

[liggitt]

the tombstone is good, though FYI, if we reimplement NetworkPolicyStatus in a future release, the type will have to be compatible with the current type, since the json field name of status would overlap for clients linked to API types that had the status field

[liggitt]

/hold cancel

[rikatz]

thanks @liggitt and @thockin

I will find someone to approve the testdata as this one apparently does need specific approval.

[rikatz]

/cc @dims @johnbelamaric
for testdata approval

[dims]

/approve
/lgtm
/skip

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, rikatz, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• api/OWNERS [thockin]
• pkg/apis/OWNERS [thockin]
• pkg/features/OWNERS [dims,thockin]
• pkg/generated/openapi/OWNERS [dims,thockin]
• pkg/registry/networking/OWNERS [dims,thockin]
• staging/src/k8s.io/api/OWNERS [thockin]
• staging/src/k8s.io/client-go/OWNERS [dims,thockin]
• test/conformance/testdata/OWNERS [dims]
• test/e2e/network/netpol/OWNERS [dims,thockin]
• test/integration/apiserver/OWNERS [dims,thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cici37]

/triage accepted