Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e framework: revise import restrictions #115710

Merged
merged 1 commit into from
Feb 21, 2023
Merged

e2e framework: revise import restrictions #115710

merged 1 commit into from
Feb 21, 2023

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Feb 12, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • test/e2e/framework/*.go should have very minimal dependencies. We can enforce that via import-boss.

  • What each test/e2e/framework/* sub-package uses is less relevant, although ideally it also should be as minimal as possible in each case.

Enforcing this via import-boss ensures that new dependencies get flagged as problem and thus will get additional scrutiny. It might be okay to add them, but it needs to be considered.

Which issue(s) this PR fixes:

Fixes #115234

Special notes for your reviewer:

See #115296 for some prior discussion.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 12, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 12, 2023
@pohly
e2e: revise import restrictions
3e76031 
- test/e2e/framework/*.go should have very minimal dependencies.
  We can enforce that via import-boss.

- What each test/e2e/framework/* sub-package uses is less relevant,
  although ideally it also should be as minimal as possible in each case.

Enforcing this via import-boss ensures that new dependencies get flagged as
problem and thus will get additional scrutiny. It might be okay to add them,
but it needs to be considered.
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2023
@pohly pohly mentioned this pull request Feb 12, 2023
Closed
@pohly
Copy link
Contributor Author

pohly commented Feb 12, 2023

/retest

@dims
Copy link
Member

dims commented Feb 20, 2023

/assign @pohly

@pohly
Copy link
Contributor Author

pohly commented Feb 20, 2023

/assign @oomichi

You might still have some context on why the import restrictions were added initially?

oomichi
oomichi reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pohly
Thanks for doing that.
I see the point of this pull request.

/lgtm

test/e2e/framework/.import-restrictions
# which means that it shouldn't depend on internal
# code. But we are not there yet, so some exceptions
# have to be allowed. Over time the list of allowed
# packages should get shorter, not longer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the above comment.
We tried to solve the dependency issue so hardly, but we saw that is hard to do that actually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done now 😁

The last remaining issue is embedding code that is only used by test/e2e_node inside test/e2e/framework (mostly for the TestContext). That pulls in the k/k/pkg dependency.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 43fc520b7b0fe6676cb5e2cf9746b9b60b5a1b8f

@oomichi
Copy link
Member

oomichi commented Feb 21, 2023

/test pull-kubernetes-e2e-gci-gce-ipvs

@k8s-ci-robot k8s-ci-robot merged commit 487c443 into kubernetes:master Feb 21, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 21, 2023
@alexzielenski alexzielenski mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@bowei bowei Awaiting requested review from bowei

Assignees

@pohly pohly

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

hack/verify-test-code.sh: replace with proper linter
4 participants
@pohly @k8s-ci-robot @dims @oomichi