Add atiratree as sig-apps reviewer #114633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
sig/apps
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/cc @atiratree thank you very much for your help 💯 |
|
+1 |
|
/approve @atiratree totally new ball game being a reviewer! :) |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8bd30654deb03db9a3cbef9fec65fd9d240f459f
|
|
Thanks a lot everyone! 🎉 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, kow3ns, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/remove-hold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
/sig apps
What this PR does / why we need it:
Filip has been a member of kubernetes org for over a year now, but he has been actively working with sig-apps for longer than that. Initially joining our bi-weekly calls, but over time sharing opinions, reviewing and finally contributing code. By now he authored more than 20 PRs, reviewed more than 30 PRs across majority of the controllers (replica set, hpa, cronjob, daemonset, statefulset, controller revision), out of which more than 10 he was acting as the primary reviewer. Recently he has been responsible for delivering PodHealthyPolicy for PodDisruptionBudget feature. Finally, he recently graduated from sig-apps mentoring.
With all of the above, I can confidently promote Filip to sig-apps reviewer.
Special notes for your reviewer:
/assign @janetkuo @kow3ns @dims
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: