kubelet: create top-level traces for pod sync and GC #114504

vrutkovs · 2022-12-15T13:13:13Z

This adds top level OpenTelemetry spans to most common goroutines periodically invoked by kubelet:

syncPod
ImageGCManager.GarbageCollect
ContainerGC.GarbageCollect

Other GRPC calls will be nested below these spans grouping CRI calls

What type of PR is this?

/kind feature

What this PR does / why we need it:

Creates top level OpenTelemetry spans whenever:

kubelet pod sync needs syncing
kubelet starts image garbage collection
kubelet starts container garbage collection

This would group kubelet GRPC span under a single span showing the source of these calls

Which issue(s) this PR fixes:

Part of #113414

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Part of KEP kubernetes/enhancements#2831

- [KEP]: [Kubelet tracing KEP](https://github.com/kubernetes/enhancements/issues/2831)

k8s-ci-robot · 2022-12-15T13:13:21Z

Welcome @vrutkovs!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-12-15T13:13:22Z

Hi @vrutkovs. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2022-12-15T13:14:04Z

/sig node
/cc @saschagrunert @dashpole @sallyom

dashpole · 2022-12-15T17:33:59Z

/assign
/triage accepted
/ok-to-test
/priority important-longterm

vrutkovs · 2022-12-15T19:06:04Z

pkg/kubelet/images/image_gc_manager_test.go

@@ -594,7 +597,7 @@ func TestGarbageCollectNotEnoughFreed(t *testing.T) {
 	manager, fakeRuntime := newRealImageGCManager(policy, mockStatsProvider)

 	// Expect 95% usage and little of it gets freed.
-	mockStatsProvider.EXPECT().ImageFsStats(ctx).Return(&statsapi.FsStats{
+	mockStatsProvider.EXPECT().ImageFsStats(gomock.Any()).Return(&statsapi.FsStats{


Not sure about this one - we can't use ctx as it gets mutated (trace attributes being added). Any better way other than replacing it with gomock.Any()?

swagatbora90

LGTM!

sallyom

lgtm

saschagrunert · 2023-03-06T15:11:15Z

@sergeyevstifeev do you have the approver rights for the kubelet part?

This starts new top level OpenTelemetry spans every time syncPod or image / container GC is invoked

vrutkovs · 2023-03-11T13:35:41Z

/test pull-kubernetes-node-e2e-containerd

k8s-ci-robot · 2023-03-13T23:11:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, dashpole, mrunalp, sallyom, saschagrunert, swagatbora90, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~hack/verify-flags/OWNERS~~ [ardaguclu]
~~pkg/kubelet/OWNERS~~ [mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

saschagrunert · 2023-03-14T08:24:10Z

/retest

saschagrunert · 2023-03-14T08:24:20Z

/lgtm

k8s-ci-robot · 2023-03-14T08:24:26Z

LGTM label has been added.

Git tree hash: 2f5e755662cb10934aed17e7d7093a62d10af126

saschagrunert · 2023-03-14T09:30:50Z

/milestone v1.27

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 15, 2022

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 15, 2022

k8s-ci-robot requested review from dashpole, sallyom and saschagrunert December 15, 2022 13:14

k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 15, 2022

k8s-ci-robot requested a review from pacoxu December 15, 2022 13:14

k8s-ci-robot added area/kubelet sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Dec 15, 2022

k8s-ci-robot assigned dashpole Dec 15, 2022

vrutkovs force-pushed the tracing-kubelet-toplevel branch from ba391ce to 84474d4 Compare December 15, 2022 19:04

vrutkovs commented Dec 15, 2022

View reviewed changes

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2023

k8s-ci-robot requested review from ardaguclu, dashpole, sallyom and saschagrunert February 28, 2023 16:08

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2023

vrutkovs force-pushed the tracing-kubelet-toplevel branch from 28d50fa to e7a4d15 Compare February 28, 2023 16:10

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2023

swagatbora90 approved these changes Feb 28, 2023

View reviewed changes

sallyom approved these changes Mar 6, 2023

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2023

kubelet: create top-level traces for pod sync and GC

556d774

This starts new top level OpenTelemetry spans every time syncPod or image / container GC is invoked

vrutkovs force-pushed the tracing-kubelet-toplevel branch from e7a4d15 to 556d774 Compare March 11, 2023 09:42

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2023

mrunalp approved these changes Mar 13, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023

k8s-ci-robot added this to the v1.27 milestone Mar 14, 2023

k8s-ci-robot merged commit c8f001d into kubernetes:master Mar 14, 2023

SIG Node PR Triage automation moved this from Needs Approver to Done Mar 14, 2023

mborsz mentioned this pull request Mar 15, 2023

Add missing trace dependency to kubemark #116645

Merged

pacoxu mentioned this pull request Mar 15, 2023

Failure cluster [ee841810...] ci-kubernetes-kubemark-500-gce failed after code freeze #116646

Closed

dashpole mentioned this pull request Nov 6, 2023

Connected traces in the kubelet #113414

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubelet: create top-level traces for pod sync and GC #114504

kubelet: create top-level traces for pod sync and GC #114504

vrutkovs commented Dec 15, 2022 •

edited

k8s-ci-robot commented Dec 15, 2022

k8s-ci-robot commented Dec 15, 2022

vrutkovs commented Dec 15, 2022

dashpole commented Dec 15, 2022

vrutkovs Dec 15, 2022 •

edited

swagatbora90 left a comment

sallyom left a comment

saschagrunert commented Mar 6, 2023 •

edited

vrutkovs commented Mar 11, 2023

k8s-ci-robot commented Mar 13, 2023

saschagrunert commented Mar 14, 2023

saschagrunert commented Mar 14, 2023

k8s-ci-robot commented Mar 14, 2023

saschagrunert commented Mar 14, 2023

kubelet: create top-level traces for pod sync and GC #114504

kubelet: create top-level traces for pod sync and GC #114504

Conversation

vrutkovs commented Dec 15, 2022 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Dec 15, 2022

k8s-ci-robot commented Dec 15, 2022

vrutkovs commented Dec 15, 2022

dashpole commented Dec 15, 2022

vrutkovs Dec 15, 2022 • edited

Choose a reason for hiding this comment

swagatbora90 left a comment

Choose a reason for hiding this comment

sallyom left a comment

Choose a reason for hiding this comment

saschagrunert commented Mar 6, 2023 • edited

vrutkovs commented Mar 11, 2023

k8s-ci-robot commented Mar 13, 2023

saschagrunert commented Mar 14, 2023

saschagrunert commented Mar 14, 2023

k8s-ci-robot commented Mar 14, 2023

saschagrunert commented Mar 14, 2023

vrutkovs commented Dec 15, 2022 •

edited

vrutkovs Dec 15, 2022 •

edited

saschagrunert commented Mar 6, 2023 •

edited