hack/tools: update golangci-lint version (1.48.0 -> 1.50.0)

[oscr]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update golangci-lint version from 1.48.0 -> 1.50.0. This makes some interesting new linters available.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

@oscr: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aojea]

there are some deprecations golangci/golangci-lint#3125 , I think we need to check if we have to adapt our configuration

kubernetes/.golangci.yaml

Lines 17 to 45 in 9bcb81e

	enable: # please keep this alphabetized
	# Don't use soon to deprecated[1] linters that lead to false
	# https://github.com/golangci/golangci-lint/issues/1841
	# - deadcode
	# - structcheck
	# - varcheck
	- ineffassign
	- logcheck
	- staticcheck
	- stylecheck
	- unused
	linters-settings: # please keep this alphabetized
	custom:
	logcheck:
	# Installed there by hack/verify-golangci-lint.sh.
	path: _output/local/bin/logcheck.so
	description: structured logging checker
	original-url: k8s.io/klog/hack/tools
	staticcheck:
	checks: [
	"all",
	"-SA1019", # TODO(fix) Using a deprecated function, variable, constant or field
	"-SA2002" # TODO(fix) Called testing.T.FailNow or SkipNow in a goroutine, which isn’t allowed
	]
	stylecheck:
	checks: [
	"ST1019", # Importing the same package multiple times.
	]

[oscr]

there are some deprecations golangci/golangci-lint#3125 , I think we need to check if we have to adapt our configuration

Sure thing! Since they are replaced by unused which is also configured to run I removed the deprecated linters.

[aojea]

/lgtm
/assign @BenTheElder @thockin

[dims]

/sig testing
/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, oscr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dims]
• hack/OWNERS [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment