Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #111752: Revert "client-go: remove no longer used #112055

Merged
merged 2 commits into from Sep 7, 2022
Merged

Automated cherry pick of #111752: Revert "client-go: remove no longer used #112055

merged 2 commits into from Sep 7, 2022

Conversation

aanm
Copy link
Contributor

@aanm aanm commented Aug 26, 2022 •
edited by liggitt

Cherry pick of #111752 on release-1.25.

#111752: Revert "client-go: remove no longer used

For details on the cherry pick process, see the cherry pick requests page.

Revert 1.24 regression that prevented client-go latency metrics to be reported with a template URL to avoid label cardinality.

@aanm
Revert "client-go: remove no longer used finalURLTemplate"
11e16c6 
The functionality provided by the finalURLTemplate is still used by
certain external projects to track the request latency for requests
performed to kube-apiserver.

Using a template of the URL, instead of the URL itself, prevents the
explosion of label cardinality in exposed metrics since it aggregates
the URLs in a way that common URLs requests are reported as being the
same.

This reverts commit bebf5a6.

Signed-off-by: André Martins <aanm90@gmail.com>
@aanm
client-go/rest: check if url is nil to prevent nil pointer dereference
fa1d4c3 
Signed-off-by: André Martins <aanm90@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 26, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 26, 2022
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 26, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 26, 2022
@aanm
Copy link
Contributor Author

aanm commented Aug 26, 2022

/kind bug
/kind cleanup

/kind api-change
/kind regression

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/regression Categorizes issue or PR as related to a regression from a prior release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 26, 2022
@aanm
Copy link
Contributor Author

aanm commented Aug 26, 2022

/test pull-kubernetes-unit

@aojea
Copy link
Member

aojea commented Aug 26, 2022

/lgtm

Thanks

/assign @liggitt
for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2022
@liggitt
Copy link
Member

liggitt commented Aug 26, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aanm, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2022
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 30, 2022
@puerco
Copy link
Member

puerco commented Sep 6, 2022

Thanks @aanm !
/lgtm
/priority improtant-soon

@k8s-ci-robot
Copy link
Contributor

@puerco: The label(s) priority/improtant-soon cannot be applied, because the repository doesn't have them.

In response to this:

Thanks @aanm !
/lgtm
/priority improtant-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 6, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 6, 2022
lojies
lojies reviewed Sep 6, 2022
View reviewed changes
Copy link
Contributor

@lojies lojies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@puerco
Copy link
Member

puerco commented Sep 7, 2022

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4a017e9 into kubernetes:release-1.25 Sep 7, 2022
@aanm aanm deleted the automated-cherry-pick-of-#111752-origin-gh-aanm-release-1.25 branch September 7, 2022 08:44
@liggitt liggitt removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lojies lojies lojies left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

@puerco puerco

@aojea aojea

@lojies lojies

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aanm @aojea @liggitt @k8s-ci-robot @leilajal @puerco @lojies