Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop panic in govet levee under golang 1.19 #111677

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Stop panic in govet levee under golang 1.19 #111677

merged 2 commits into from
Aug 4, 2022

Conversation

dims
Copy link
Member

@dims dims commented Aug 4, 2022 •
edited

Related to #111452

In this PR, we just ensure that if someone runs ./hack/verify-govet-levee.sh we do not fail/panic. Thanks to suggestion @timothy-king at golang/go#54086 (comment)

Tested with golang 1.19 GA locally

[dims@dims-m1-7728 21:56] ~/go/src/k8s.io/kubernetes ⟩ hack/verify-govet-levee.sh
NOTE: /Users/dims/go/src/k8s.io/kubernetes/hack/verify-govet.sh has been replaced by 'make vet'

The equivalent of this invocation is:
    make vet WHAT='-vettool=/Users/dims/go/src/k8s.io/kubernetes/_output/local/bin/levee -config=/Users/dims/go/src/k8s.io/kubernetes/hack/testdata/levee/levee-config.yaml'


+++ [0803 21:56:23] Building go targets for darwin/arm64
    k8s.io/kubernetes/hack/make-rules/helpers/go2make (non-static)
+++ [0803 21:56:29] Building go targets for darwin/arm64
    k8s.io/code-generator/cmd/prerelease-lifecycle-gen (non-static)
+++ [0803 21:56:30] Generating prerelease lifecycle code for       26 targets
+++ [0803 21:56:32] Building go targets for darwin/arm64
    k8s.io/code-generator/cmd/deepcopy-gen (non-static)
+++ [0803 21:56:34] Generating deepcopy code for      241 targets
+++ [0803 21:56:38] Building go targets for darwin/arm64
    k8s.io/code-generator/cmd/defaulter-gen (non-static)
+++ [0803 21:56:39] Generating defaulter code for       94 targets
+++ [0803 21:56:43] Building go targets for darwin/arm64
    k8s.io/code-generator/cmd/conversion-gen (non-static)
+++ [0803 21:56:44] Generating conversion code for      131 targets
+++ [0803 21:56:57] Building go targets for darwin/arm64
    k8s.io/kube-openapi/cmd/openapi-gen (non-static)
+++ [0803 21:56:58] Generating openapi code for KUBE
+++ [0803 21:57:07] Generating openapi code for AGGREGATOR
+++ [0803 21:57:07] Generating openapi code for APIEXTENSIONS
+++ [0803 21:57:08] Generating openapi code for CODEGEN
+++ [0803 21:57:08] Generating openapi code for SAMPLEAPISERVER
  1 run lint-dependencies and follow directions
# sync/atomic
unexpected type received: *types.TypeParam T; please report this issue
unexpected type received: *types.TypeParam T; please report this issue
unexpected type received: *types.TypeParam T; please report this issue
unexpected type received: *types.TypeParam T; please report this issue
# crypto/elliptic
unexpected type received: *types.TypeParam Point; please report this issue

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@dims
Stop panic in govet-levee CI job
30e2fcd 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims
run lint-dependencies and follow directions
34742f2 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 4, 2022
@dims
Copy link
Member Author

dims commented Aug 4, 2022

/release-note-none
/sig architecture

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 4, 2022
@dims
Copy link
Member Author

dims commented Aug 4, 2022

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 4, 2022
@dims
Copy link
Member Author

dims commented Aug 4, 2022

/assign @nikhita @liggitt @MadhavJivrajani

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Aug 4, 2022
@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Aug 4, 2022
@liggitt
Copy link
Member

liggitt commented Aug 4, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@BenTheElder
Copy link
Member

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 4, 2022
@MadhavJivrajani MadhavJivrajani mentioned this pull request Aug 4, 2022
Merged
@MadhavJivrajani
Copy link
Contributor

MadhavJivrajani commented Aug 4, 2022 •
edited

/test pull-kubernetes-e2e-kind

@aojea
Copy link
Member

aojea commented Aug 4, 2022

👌👌👌

@k8s-ci-robot k8s-ci-robot merged commit ef7fc10 into kubernetes:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@brianpursley brianpursley Awaiting requested review from brianpursley

Assignees

@liggitt liggitt

@MadhavJivrajani MadhavJivrajani

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dims @liggitt @k8s-ci-robot @BenTheElder @MadhavJivrajani @aojea @nikhita