Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick up major changes from cel-go latest release #111071

Merged
merged 6 commits into from Jul 21, 2022
Merged

Pick up major changes from cel-go latest release #111071

merged 6 commits into from Jul 21, 2022

Conversation

cici37
Copy link
Contributor

@cici37 cici37 commented Jul 11, 2022 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

cel-go bumped to v0.12.0 recently(#111008) and involved some changes regarding:

This PR includes:

  1. Adopt the changes regarding with dispatcher refractor
  2. Turn on defaultUTCTimezone feature.
  3. Turn on support for empty list sum

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This PR is based on #111008.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/2876-crd-validation-expression-language/README.md

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 11, 2022
@k8s-ci-robot k8s-ci-robot requested review from brianpursley, cheftako and a team July 11, 2022 15:52
@cici37
Copy link
Contributor Author

cici37 commented Jul 11, 2022

/test all

@cici37 cici37 changed the title Pick up latest changes from cel-go Pick up dispatcher refactor from cel-go Jul 11, 2022
@cici37
Copy link
Contributor Author

cici37 commented Jul 11, 2022

/cc @jpbetz @TristonianJones
The env initialization process err out with overload signature collision in function max: list_bool_max_bool collides with list_int_max_int. It seems related with how cel deal with list or if anything I might missed. Would you mind to take a look when have time? Thank you

@k8s-ci-robot k8s-ci-robot requested a review from jpbetz July 11, 2022 16:32
@k8s-ci-robot
Copy link
Contributor

@cici37: GitHub didn't allow me to request PR reviews from the following users: TristonianJones.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jpbetz @TristonianJones
The env initialization process err out with overload signature collision in function max: list_bool_max_bool collides with list_int_max_int. It seems related with how cel deal with list or if anything I might missed. Would you mind to take a look when have time? Thank you

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cici37
Copy link
Contributor Author

cici37 commented Jul 14, 2022

The PR is ready for review now. It contains:

  1. Bump cel-go to v0.12.4
  2. Adopt the dispatch refactor
  3. Turn on defaultUTCTimezone feature which aligns with what is written in cel-go spec.
  4. Add support for empty list sum

/assign @liggitt
Would you mind to take a look when have time? Thank you so much 😊

liggitt
liggitt reviewed Jul 14, 2022
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependency bump lgtm, would like a review on the cel/library changes by someone with more familiarity with that package (e.g. @jpbetz)

staging/src/k8s.io/apiextensions-apiserver/third_party/forked/celopenapi/model/url.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiextensions-apiserver/third_party/forked/celopenapi/model/types.go Show resolved Hide resolved
staging/src/k8s.io/apiextensions-apiserver/third_party/forked/celopenapi/model/schemas.go Outdated Show resolved Hide resolved
@liggitt
Copy link
Member

liggitt commented Jul 14, 2022

flake is #111118

@cici37 cici37 mentioned this pull request Jul 14, 2022
Closed
10 tasks
@liggitt
Copy link
Member

liggitt commented Jul 15, 2022

/assign @jpbetz
for review of the library stuff

/unassign
re-tag me when this is ready for dep ack

@k8s-ci-robot k8s-ci-robot assigned jpbetz and unassigned liggitt Jul 15, 2022
@cici37
Copy link
Contributor Author

cici37 commented Jul 15, 2022

Hi @jpbetz Here is the test added for maxRecurionDepth for reference:

kubernetes/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/cel/validation_test.go

Line 1932 in d968912

// This is the most recursive operations we expect to be able to include in an expression.

@jpbetz
Copy link
Contributor

jpbetz commented Jul 20, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2022
@liggitt
Copy link
Member

liggitt commented Jul 20, 2022

/approve
for dependency update

deferring to @jpbetz review of CEL changes at #111071 (comment)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cici37, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@jpbetz
Copy link
Contributor

jpbetz commented Jul 20, 2022

/retest

1 similar comment
@cici37
Copy link
Contributor Author

cici37 commented Jul 21, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 303f47c into kubernetes:master Jul 21, 2022
@cici37 cici37 deleted the updateCEL branch July 21, 2022 06:56
@cici37 cici37 mentioned this pull request Jul 29, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TristonianJones TristonianJones TristonianJones left review comments

@liggitt liggitt liggitt left review comments

@jpbetz jpbetz jpbetz requested changes

@brianpursley brianpursley Awaiting requested review from brianpursley

@cheftako cheftako Awaiting requested review from cheftako

@apelisse apelisse Awaiting requested review from apelisse

@bobbypage bobbypage Awaiting requested review from bobbypage

Assignees

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cici37 @k8s-ci-robot @leilajal @liggitt @jpbetz @k8s-triage-robot @TristonianJones