Mock and unit testcases added for windows kube-proxy.

[princepereira]

What type of PR is this?

/kind cleanup
/kind failing-test
/kind windows
/kind kube-proxy

What this PR does / why we need it:

This is to add mock and unit tests for windows kube-proxy

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

@princepereira: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: princepereira / name: PRINCE PEREIRA (3663842fec0fe26d3b6eabcff060aff429bd4def)

[k8s-ci-robot]

Welcome @princepereira!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @princepereira. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jsturtevant]

/sig windows
/ok-to-test

[jsturtevant]

alternative/related to #110749

[daschott]

Is there a reason to mock all the hcnUtils? To my understanding all of these are helpers that ultimately call into HCN.

Would it perhaps be better to only mock all of the hcsshim/HCN signature that the hcnUtils use? Store any of the created endpoints/loadbalancers as part of the "HCN" mock in memory and remove the structs/interfaces that mock hcnUtils. Tests and proxier code would use the same hcnUtils code.

hcnUtils for tests would initialize the hcn mock package which store artificial endpoints/loadbalancers, and real proxier code would use hcnUtils that initializes/references real hcn package.

Maybe I am missing something but feels to me this might reduce a layer of abstraction and make the code easier to understand, without reducing robustness of tests. Curious to hear your thoughts?

[princepereira]

hcnUtils is the final place where the test cases have control to mock the function call in the existing implementation. Considering an example of network.createEndpoint():

network.createEndpoint() -Calls-> createEndpoint [Which is in hcn package of vendor directory] -Calls-> hcnOpenNetwork [Which is in hcn package of vendor directory] -Calls-> syscall.Syscall

If you have a look at the above call flow, test code dont have any handle to avoid the syscall. That's the reason behind mocking hncUtils.

And sorry for the delay in responding, missed out the comment somehow.

[princepereira]

@daschott , Please review the code when you get a chance.

[k8s-ci-robot]

@princepereira: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[marosset]

/milestone v1.27
/triage accepted
/priority important-soon

[dims]

If you still need this PR then please rebase, if not, please close the PR

[dims]

If you still need this PR then please remove the merge commits (see bot comment above), if not, please close the PR

[claudiubelu]

/cc @claudiubelu

[claudiubelu]

/assign

[furkatgofurov7]

@princepereira @claudiubelu HI! Release Bug Triage Shadow here.

This PR hasn't been updated in 3 months. I just wanted to check if this is still on track for 1.27 release?

[furkatgofurov7]

Hi @princepereira!

K8s 1.27 Bug Triage Shadow here again.
FYI, with Code Freeze approaching next week on March 15th, if you would like this PR to be part of the v1.27 release, please make sure it goes in before above mentioned date. Post Code Freeze, we will only be able to accept Release Blockers and Critical issues. Thank you!

[dims]

@princepereira please rebase!

[liggitt]

/milestone clear

since this is touching code outside of test files after code freeze

[dims]

Please remove merge commits, rebase and reopen this PR if necessary. It will not be merged as-is