Fix pod's deadline to nil when cache ttl is set to zero

[kerthcet]

Signed-off-by: kerthcet kerthcet@gmail.com

What type of PR is this?

/kind bug
/sig scheduling

What this PR does / why we need it:

Pod's deadline in podState should be nil when we set the cache ttl to zero.

Which issue(s) this PR fixes:

Part of #106361

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

@kerthcet: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

Is this a bug or a cleanup?

If it's a cleanup, maybe not worth merging, since we plan to remove the code anyways

/shrug

[kerthcet]

Is this a bug or a cleanup?

Honestly I would like to treat it as a bug for we have data error internal, but it has no side effect up to now.

If it's a cleanup, maybe not worth merging, since we plan to remove the code anyways

As discussed before, we still have two more releases before we finally remove them, and this discussion is still pending, I think we should fix it.

[alculquicondor]

Honestly I would like to treat it as a bug for we have data error internal, but it has no side effect up to now.

That's a cleanup then. It has no real effect and all the information is in-memory (not in etcd).

/type cleanup
/remove-type bug

[alculquicondor]

I think you could leave this like so:

Suggested change

	durationToExpireAssumedPod = 0 * time.Second
	durationToExpireAssumedPod = 0

or

Suggested change

	durationToExpireAssumedPod = 0 * time.Second
	durationToExpireAssumedPod time.Duration = 0

[kerthcet]

Picked the second one.

[alculquicondor]

Please squash

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kerthcet]

squashed.

[alculquicondor]

/lgtm
/priority backlog

[k8s-ci-robot]

@kerthcet: you cannot LGTM your own PR.

In response to this:

Since @alculquicondor has lgtmed but not triggered by the CI, I'll add this label again.
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kerthcet]

Plz add lgtm again @alculquicondor the CI didn't work last time. Thanks.

[alculquicondor]

/lgtm
/priority backlog

[alculquicondor]

flaky test: #110962

/retest

[ahg-g]

/remove-kind bug
/kind cleanup