Commits on Jun 30, 2022

1. kubelet: revert contextual logging support …

   It turned out that using testing.T for logging had a race condition and
   potential panic because the tests keep goroutines running and testing.T is not
   supposed to be used anymore after test
   completion (kubernetes#110854).
   
   Either the code must be fixed to terminate all goroutines before a test
   ends (seems non-trivial because the usage of goroutines is fairly complex in
   the shutdown manager code), or ktesting must handle this case. A solution for
   this is pending in kubernetes/klog#337.
   
   Either way, solving this will take a bit longer. In the meantime, we should
   revert the change to get unit testing stable again.
   
   In order to make this a local change, ktesting is kept as a dependency of the
   test and thus Kubernetes.

   

   pohly committed Jun 30, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 8384e72
   • Browse repository at this point

   Copy the full SHA

   8384e72 View commit details

   Browse the repository at this point in the history