Add the UNIX prefix of the CSI address. #109559

LuJunlai1996 · 2022-04-20T08:03:01Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

Target should start with unix: to avoid setting empty authority header according to RFC-3986.

grpc/grpc-go#2628
grpc/grpc-go#3730

Which issue(s) this PR fixes:

Fixes #107093
Fixes #109081
Fixes #108254

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

k8s-ci-robot · 2022-04-20T08:03:03Z

Please note that we're already in Test Freeze for the release-1.24 branch. This means every merged PR has to be cherry-picked into the release branch to be part of the upcoming v1.24.0 release.

k8s-ci-robot · 2022-04-20T08:03:09Z

@LuJunlai1996: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2022-04-20T08:03:09Z

Welcome @LuJunlai1996!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-04-20T08:03:10Z

Hi @LuJunlai1996. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2022-04-20T08:03:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LuJunlai1996
To complete the pull request process, please assign xing-yang after the PR has been reviewed.
You can assign the PR to them by writing /assign @xing-yang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

pkg/volume/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LuJunlai1996 · 2022-04-20T08:50:39Z

/release-note-none

LuJunlai1996 · 2022-04-24T11:30:47Z

/assign @Jiawei0227

@Jiawei0227 @saikat-royc may I ask you to approve this one?

mythi · 2022-04-26T14:01:09Z

pkg/volume/csi/csi_client.go

+	unixPrefix := "unix://"
+	if strings.HasPrefix(address, "/") {
+		// It looks like filesystem path.
+		address = unixPrefix + address


need to take windows into account too?

Thanks for the reminder, resolved.

k8s-triage-robot · 2022-07-26T13:42:48Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-ci-robot · 2022-07-27T05:36:08Z

@LuJunlai1996: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2022-08-26T06:02:16Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2022-09-25T06:38:03Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2022-09-25T06:38:08Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 20, 2022

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 20, 2022

k8s-ci-robot requested review from Jiawei0227 and saikat-royc April 20, 2022 08:03

k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 20, 2022

saschagrunert mentioned this pull request Apr 20, 2022

Enable testfreeze plugin for k/k kubernetes/test-infra#25644

Merged

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 20, 2022

k8s-ci-robot assigned Jiawei0227 Apr 24, 2022

LuJunlai1996 force-pushed the master branch from 97fc787 to 460dc7a Compare April 25, 2022 04:11

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2022

mythi reviewed Apr 26, 2022

View reviewed changes

Add the UNIX prefix of the CSI address.

f5507f7

LuJunlai1996 force-pushed the master branch from 460dc7a to f5507f7 Compare April 27, 2022 12:52

k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 27, 2022

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 27, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 26, 2022

mythi mentioned this pull request Sep 20, 2022

grpc: set localhost Authority to unix client calls #112597

Merged

k8s-ci-robot closed this Sep 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the UNIX prefix of the CSI address. #109559

Add the UNIX prefix of the CSI address. #109559

LuJunlai1996 commented Apr 20, 2022 •

edited

k8s-ci-robot commented Apr 20, 2022

k8s-ci-robot commented Apr 20, 2022

k8s-ci-robot commented Apr 20, 2022

k8s-ci-robot commented Apr 20, 2022

k8s-ci-robot commented Apr 20, 2022

LuJunlai1996 commented Apr 20, 2022

LuJunlai1996 commented Apr 24, 2022

mythi Apr 26, 2022

LuJunlai1996 Apr 27, 2022

k8s-triage-robot commented Jul 26, 2022

k8s-ci-robot commented Jul 27, 2022

k8s-triage-robot commented Aug 26, 2022

k8s-triage-robot commented Sep 25, 2022

k8s-ci-robot commented Sep 25, 2022

Add the UNIX prefix of the CSI address. #109559

Add the UNIX prefix of the CSI address. #109559

Conversation

LuJunlai1996 commented Apr 20, 2022 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

k8s-ci-robot commented Apr 20, 2022

k8s-ci-robot commented Apr 20, 2022

k8s-ci-robot commented Apr 20, 2022

k8s-ci-robot commented Apr 20, 2022

k8s-ci-robot commented Apr 20, 2022

LuJunlai1996 commented Apr 20, 2022

LuJunlai1996 commented Apr 24, 2022

mythi Apr 26, 2022

Choose a reason for hiding this comment

LuJunlai1996 Apr 27, 2022

Choose a reason for hiding this comment

k8s-triage-robot commented Jul 26, 2022

k8s-ci-robot commented Jul 27, 2022

k8s-triage-robot commented Aug 26, 2022

k8s-triage-robot commented Sep 25, 2022

k8s-ci-robot commented Sep 25, 2022

LuJunlai1996 commented Apr 20, 2022 •

edited