Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetworkPolicyStatus to ineligible_endpoints.yaml #109294

Merged

Conversation

riaankleinhans
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Add NetworkPolicyStatus endpoints to ineligible_endpoint.yaml as the endpoints are currently future gated and will only recieve e2e & confromance tests in 1.25. This would prevent the endpoints for incorrectly showing up as new conformance technical debt.

  • readNetworkingV1NamespacedNetworkPolicyStatus
  • patchNetworkingV1NamespacedNetworkPolicyStatus
  • replaceNetworkingV1NamespacedNetworkPolicyStatus`

Implementation on Network Policy Status #107963

Special notes for your reviewer:
As of 1.22 APISnoop Ineligible endpoints are pulled from the community owned inelegible_endpoint.yaml file

Does this PR introduce a user-facing change?:

NONE

Release note:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig architecture
/area conformance

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 4, 2022
@riaankleinhans
Copy link
Contributor Author

/triage accepted
/assign @johnbelamaric @rikatz

Should be in milestone 1.24

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 4, 2022
@riaankleinhans
Copy link
Contributor Author

/cc @hh

@k8s-ci-robot k8s-ci-robot requested a review from hh April 4, 2022 19:48
@rikatz
Copy link
Contributor

rikatz commented Apr 4, 2022

/lgtm
Tks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2022
@riaankleinhans
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

Unrelated flake

I0404 20:15:29.353]   test/e2e/autoscaling/dns_autoscaling.go:169
I0404 20:15:29.353] STEP: Replace the dns autoscaling parameters with testing parameters
I0404 20:15:29.353] Apr  4 20:14:51.340: INFO: DNS autoscaling ConfigMap updated.
I0404 20:15:29.353] STEP: Wait for kube-dns scaled to expected number
I0404 20:15:29.353] Apr  4 20:14:51.340: INFO: Waiting up to 5m0s for kube-dns to reach expected replicas
I0404 20:15:29.354] Apr  4 20:14:53.463: INFO: Replicas not as expected: got 2, expected 3
I0404 20:15:29.354] Apr  4 20:14:55.465: INFO: Replicas not as expected: got 2, expected 3
I0404 20:15:29.354] Apr  4 20:14:57.463: INFO: Replicas not as expected: got 2, expected 3
I0404 20:15:29.354] Apr  4 20:14:59.468: INFO: Replicas not as expected: got 2, expected 3

@dims
Copy link
Member

dims commented Apr 4, 2022

/approve
/lgtm

(will still need testdata approver as i don't have privileges here)

@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, johnbelamaric, Riaankl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2022
@dims
Copy link
Member

dims commented Apr 5, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 66369f4 into kubernetes:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants