New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-enum CSR condition field, omit enums from static openapi snapshot #109178
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @jiahuif |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
#109182 flake /retest |
/retest |
/priority critical-urgent |
New changes are detected. LGTM label has been removed. |
/retest |
rebased after #109195 merged, readding tag |
This PR seems to have removed some enum explanations from the generated API docs. Could I advocate for a changelog entry that is more clear about what has happened to the OpenAPI spec as a result of this PR? (I don't think I'd have understood that entry without context). |
Currently, we do not have support for types that can be either enum or any value. Some client generators break when encountering an enum type, especially Java and Python that has built-in enum types. As a result, we have to undo the generated comments from enum types generator. |
updated the changelog |
I also filed #109463 to cover the new gap in our API docs |
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
Follow-up to #108639
xref #109177
Does this PR introduce a user-facing change?
/sig api-machinery
for openapi snapshot
/sig auth
for CSR API