Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration subtests #109048

Merged
merged 3 commits into from Mar 26, 2022
Merged

Integration subtests #109048

merged 3 commits into from Mar 26, 2022

Conversation

aojea
Copy link
Member

@aojea aojea commented Mar 26, 2022 •
edited

/kind flake

Fixes #

NONE

try to reduce the load on the integration job by reducing number of test that run in parallel

Splitting tests in different folders make them to stop accumulating goroutines leaked

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 26, 2022
@k8s-ci-robot
Copy link
Contributor

@aojea: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 26, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 26, 2022
@aojea aojea force-pushed the integration_subtests branch 2 times, most recently from 392b4fd to 2174121 Compare March 26, 2022 12:47
@aojea
Copy link
Member Author

aojea commented Mar 26, 2022

/assign @liggitt
some cleanups

@liggitt
Copy link
Member

liggitt commented Mar 26, 2022

Worker count drops and package splits lgtm. I'm less sure about the parallel drops

@liggitt
Copy link
Member

liggitt commented Mar 26, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member

liggitt commented Mar 26, 2022 •
edited

unit test flake #108040 (comment)

e2e test flake #108891 (comment)

/retest

@liggitt
Copy link
Member

liggitt commented Mar 26, 2022

/retest

@liggitt liggitt added this to the v1.24 milestone Mar 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 58c975a into kubernetes:master Mar 26, 2022
@liggitt liggitt mentioned this pull request Apr 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@krmayankk krmayankk Awaiting requested review from krmayankk

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aojea @k8s-ci-robot @liggitt