Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage capacity conformance #108867

Merged
merged 1 commit into from
Apr 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/conformance/testdata/conformance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2383,6 +2383,16 @@
pod.
release: v1.19
file: test/e2e/scheduling/preemption.go
- testname: CSIStorageCapacity API
codename: '[sig-storage] CSIStorageCapacity should support CSIStorageCapacities
API operations [Conformance]'
description: ' The storage.k8s.io API group MUST exist in the /apis discovery document.
The storage.k8s.io/v1 API group/version MUST exist in the /apis/mode.k8s.io discovery
document. The csistoragecapacities resource MUST exist in the /apis/storage.k8s.io/v1
discovery document. The csistoragecapacities resource must support create, get,
list, watch, update, patch, delete, and deletecollection.'
release: v1.24
file: test/e2e/storage/csistoragecapacity.go
- testname: ConfigMap Volume, text data, binary data
codename: '[sig-storage] ConfigMap binary data should be reflected in volume [NodeConformance]
[Conformance]'
Expand Down
3 changes: 1 addition & 2 deletions test/e2e/storage/csistoragecapacity.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,8 @@ var _ = utils.SIGDescribe("CSIStorageCapacity", func() {
The storage.k8s.io/v1 API group/version MUST exist in the /apis/mode.k8s.io discovery document.
The csistoragecapacities resource MUST exist in the /apis/storage.k8s.io/v1 discovery document.
The csistoragecapacities resource must support create, get, list, watch, update, patch, delete, and deletecollection.
TODO (pohly): promote to framework.ConformanceIt
*/
ginkgo.It(" should support CSIStorageCapacities API operations", func() {
framework.ConformanceIt(" should support CSIStorageCapacities API operations", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be merged after https://github.com/kubernetes/kubernetes/pull/108445/files#diff-5e1072eb7b333bc3faf7068eb5ce93d29adaad658b5bcdd52a8238c18c5f8f92R48 merges, and the resulting CI jobs are non-flaky for a couple weeks.

// Setup
cscVersion := "v1"
cscClient := f.ClientSet.StorageV1().CSIStorageCapacities(f.Namespace.Name)
Expand Down