Script kubectl kustomize update process #108857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
KnVerey
force-pushed
the
script_kustomize_update
branch
from
52d6afe
to
be5e145
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @soltysh |
soltysh
approved these changes
Mar 23, 2022
k8s-ci-robot
added
sig/cli
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KnVerey, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR scripts the manual process outlined in the Kustomize release docs. Demo: KnVerey#1. I chose hack/ as the location for this script since it uses utilities from there and invokes several of that directory's scripts. Let me know if it belongs somewhere else.
Which issue(s) this PR fixes:
None, but this related to kubernetes-sigs/kustomize#3952
Special notes for your reviewer:
This is split out of #108817. As discussed here, it is possible that a newer kyaml release will exist than the one we want to bring in. However, that is rare, and made even more unlikely by our typical release process. We can make the script accommodate version overrides in the future if needed, but Kustomize maintainers feel manual confirmation of the targeted versions is sufficient for the time being.
Does this PR introduce a user-facing change?