Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #108639: unmark non-validated types as enums. #108740

Merged
merged 3 commits into from Mar 31, 2022
Merged

Automated cherry pick of #108639: unmark non-validated types as enums. #108740

merged 3 commits into from Mar 31, 2022

Conversation

jiahuif
Copy link
Member

@jiahuif jiahuif commented Mar 16, 2022 •
edited by liggitt

Cherry pick of #108639 on release-1.23.

#108639: unmark non-validated types as enums.

For details on the cherry pick process, see the cherry pick requests page.

Fixes a 1.23 regression in published openAPI that incorrectly identified some fields as enum values

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Mar 16, 2022
@jiahuif
Copy link
Member Author

jiahuif commented Mar 16, 2022

There was some issue with GitHub webhooks and thus the bot. Labeling manually.

/sig api-machinery
/kind bug
/kind regression
/label release-note-none
/priority important-soon

@jiahuif
Copy link
Member Author

jiahuif commented Mar 16, 2022

/shrug

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 16, 2022
@k8s-ci-robot
Copy link
Contributor

@jiahuif: The label(s) /label release-note-none cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, official-cve-feed

In response to this:

There was some issue with GitHub webhooks and thus the bot. Labeling manually.

/sig api-machinery
/kind bug
/kind regression
/label release-note-none
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 16, 2022
@jiahuif
Copy link
Member Author

jiahuif commented Mar 16, 2022

/release-note-none
/unshrug
/assign @apelisse @liggitt

@k8s-ci-robot
Copy link
Contributor

@jiahuif: ¯\_(ツ)_/¯

In response to this:

/release-note-none
/unshrug
/assign @apelisse @liggitt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 16, 2022
@k8s-ci-robot k8s-ci-robot removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ labels Mar 16, 2022
@liggitt
Copy link
Member

liggitt commented Mar 16, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiahuif, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022
@jiahuif
Copy link
Member Author

jiahuif commented Mar 16, 2022

ping @kubernetes/release-managers
this is a regression that breaks some of our clients. it is important for the cherry pick to land the affected version (1.23)

@jiahuif jiahuif mentioned this pull request Mar 16, 2022
Closed
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 17, 2022
This was referenced Mar 28, 2022
Closed
Closed
Closed
Closed
@kindomLee kindomLee mentioned this pull request Mar 29, 2022
Closed
@soenkeliebau
Copy link

Are there any news on this? I am not very familiar with the Kubernetes release and backport process so I'm unsure if this is still progressing normally or has stalled at the moment?

@apelisse
Copy link
Member

This PR missed the minor release by nothing, so I think it'll be included in the next one.

@jiahuif jiahuif mentioned this pull request Mar 30, 2022
Merged
@yue9944882 yue9944882 mentioned this pull request Mar 30, 2022
Closed
@yue9944882
Copy link
Member

thanks! this pr will be very helpful for fixing kubernetes-client/java#2192

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 31, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 31, 2022
@liggitt liggitt mentioned this pull request Mar 31, 2022
Merged
@liggitt
Copy link
Member

liggitt commented Mar 31, 2022

#109179 is a follow-up to remove enums entirely from the static 1.23 openapi file captured here, since they are an alpha feature, and there are forward-compatibility implications of generating clients using enums that are not yet resolved (xref #109177)

@k8s-ci-robot k8s-ci-robot merged commit 6f3b838 into kubernetes:release-1.23 Mar 31, 2022
@roycaihw roycaihw mentioned this pull request Apr 9, 2022
Closed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 9, 2023
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@kow3ns kow3ns Awaiting requested review from kow3ns

Assignees

@liggitt liggitt

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jiahuif @k8s-ci-robot @liggitt @leilajal @soenkeliebau @apelisse @yue9944882 @Verolop