Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

klog v2.60.1 #108725

Merged
merged 3 commits into from Mar 24, 2022
Merged

klog v2.60.1 #108725

merged 3 commits into from Mar 24, 2022

Commits on Mar 21, 2022

  1. klog v2.60.1 

    The new release supports FlushAndExit and contextual logging.
    @pohly
    pohly committed Mar 21, 2022
    Copy the full SHA
    09aa107 View commit details
    Browse the repository at this point in the history

  2. logs: flush Logger through klog 

    Not all code knows that it needs to flush through component-base/logs.FlushLogs
when the JSON logger is used. By registering the flush callback together with
the logger, klog.Flush and klog.FlushAndExit are sufficient for flushing all
data.
    @pohly
    pohly committed Mar 21, 2022
    Copy the full SHA
    f8bb67c View commit details
    Browse the repository at this point in the history

  3. logs: replace our custom flush daemon with klog's daemon 

    The advantage is that klog properly handles restarting of the daemon
with a new interval and the daemon can be stopped.

Stopping the daemon solves a data race that the tests had when modifying the
Logger's flush function while goroutines from previous tests were still
running.
    @pohly
    pohly committed Mar 21, 2022
    Copy the full SHA
    0b7d303 View commit details
    Browse the repository at this point in the history