Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark PodOverhead to GA in v1.24; remove in v1.26 #108441

Merged
merged 1 commit into from Mar 17, 2022
Merged

mark PodOverhead to GA in v1.24; remove in v1.26 #108441

merged 1 commit into from Mar 17, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Mar 2, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

/sig node
some documentation and comments that mention PodOverhead should be removed when the feature is removed in v1.26.

Which issue(s) this PR fixes:

xref kubernetes/enhancements#688

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Feature of `PodOverhead` is graduated to GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/688-pod-overhead

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Mar 2, 2022
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Mar 2, 2022
@pacoxu pacoxu marked this pull request as draft March 2, 2022 03:03
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2022
@pacoxu pacoxu marked this pull request as ready for review March 2, 2022 03:10
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2022
@fedebongio
Copy link
Contributor

/assign @kubernetes/api-reviewers @kubernetes/sig-node-api-reviews
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 3, 2022
@leilajal
Copy link
Contributor

leilajal commented Mar 3, 2022

/triage accepted

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2022
@SergeyKanzhelev
Copy link
Member

and in pkg/apis/node/types.go

@SergeyKanzhelev
Copy link
Member

Thank you for submitting this @pacoxu. I was working on similar one with the Conformance test added. But those can be split and I can send conformance test separately.

Added a small nits and please update fields descriptions in various types.go files

@SergeyKanzhelev
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 15, 2022
@SergeyKanzhelev
Copy link
Member

PR for conformance test for PodOverhead: #108714

@k8s-ci-robot k8s-ci-robot added area/code-generation sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Mar 16, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Mar 16, 2022

/test pull-kubernetes-integration

@liggitt
Copy link
Member

liggitt commented Mar 16, 2022

/approve

lgtm, squash in "address comments" commit before merge

@liggitt liggitt moved this from Changes requested to API review completed, 1.24 in API Reviews Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022
@SergeyKanzhelev
Copy link
Member

lgtm

@pacoxu
Copy link
Member Author

pacoxu commented Mar 17, 2022

Thanks for reviewing.
Squashed.

@liggitt
Copy link
Member

liggitt commented Mar 17, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, liggitt, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member Author

pacoxu commented Mar 17, 2022

/test pull-kubernetes-unit

@pacoxu
Copy link
Member Author

pacoxu commented Mar 17, 2022

/retest
😂

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit a504daa into kubernetes:master Mar 17, 2022
SIG Node PR Triage automation moved this from Triage to Done Mar 17, 2022
@tengqm tengqm mentioned this pull request Mar 18, 2022
Merged
@github-actions github-actions bot mentioned this pull request Mar 22, 2022
Open
@pacoxu pacoxu deleted the pod-overload-ga branch May 10, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@chendave chendave Awaiting requested review from chendave

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.24
SIG Node PR Triage
Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pacoxu @fedebongio @leilajal @k8s-triage-robot @liggitt @SergeyKanzhelev @k8s-ci-robot @alculquicondor