Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graduate default pod topology spread to ga #108278

Merged
merged 1 commit into from Feb 28, 2022
Merged

graduate default pod topology spread to ga #108278

merged 1 commit into from Feb 28, 2022

Conversation

kerthcet
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

graduate DefaultPodTopologySpread to GA

Which issue(s) this PR fixes:

REF: kubernetes/enhancements#1258

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Feature of `DefaultPodTopologySpread` is graduated to GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/1258-default-pod-topology-spread

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 22, 2022
@k8s-ci-robot
Copy link
Contributor

@kerthcet: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2022
@kerthcet
Copy link
Member Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 22, 2022
@kerthcet
Copy link
Member Author

Hi @gavinfish , I have cherried pick your commit in this pr because it's part of v1.24 milestone and we are approaching. More importantly, this pr has the potential conflicts with my code developing, so I helped to rebase your pr. Sorry for that.
Thanks again for all your harding workings in the process of GA DefaultPodTopologySpread.

also cc @alculquicondor for review again. Thanks.

@kerthcet kerthcet mentioned this pull request Feb 22, 2022
Closed
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@alculquicondor
Copy link
Member

/label api-change

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: The label(s) /label api-change cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, official-cve-feed

In response to this:

/label api-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Member

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Feb 22, 2022
alculquicondor
alculquicondor reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2022
@kerthcet
Copy link
Member Author

/retitle graduate default pod topology spread to ga

@k8s-ci-robot k8s-ci-robot changed the title Feature/graduate default pod topology spread to ga graduate default pod topology spread to ga Feb 23, 2022
@kerthcet @gavinfish
feat: graduate DefaultPodTopologySpread to GA
4439fc3 
Co-authored-by: drfish <drfish.me@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet force-pushed the feature/graduate-defaultPodTopologySpread-to-ga branch from 793ecad to 4439fc3 Compare February 23, 2022 11:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2022
@kerthcet
Copy link
Member Author

/retest

@denkensk
Copy link
Member

/test pull-kubernetes-e2e-kind-ipv6

@denkensk
Copy link
Member

/lgtm
Thanks. @kerthcet

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2022
@alculquicondor
Copy link
Member

Now let's wait for an API reviewer to be assigned

@kerthcet
Copy link
Member Author

Kindly ping @liggitt , PTAL.

@liggitt
Copy link
Member

liggitt commented Feb 28, 2022

/approve

@liggitt liggitt self-assigned this Feb 28, 2022
@liggitt liggitt added this to API review completed, 1.24 in API Reviews Feb 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, kerthcet, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit bf7b911 into kubernetes:master Feb 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 28, 2022
@kerthcet kerthcet deleted the feature/graduate-defaultPodTopologySpread-to-ga branch February 28, 2022 16:24
This was referenced Mar 1, 2022
Closed
Merged
@reylejano reylejano mentioned this pull request Mar 23, 2022
Merged
@SataQiu SataQiu mentioned this pull request Sep 19, 2022
Merged
@alex-berger alex-berger mentioned this pull request Jul 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@denkensk denkensk denkensk left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees

@liggitt liggitt

@alculquicondor alculquicondor

@denkensk denkensk

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.24
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kerthcet @k8s-ci-robot @k8s-triage-robot @alculquicondor @denkensk @liggitt