[CI job failure containerd-e2e-ubuntu] Verify containerd only after installation #107999
Conversation
Signed-off-by: Aditi Sharma <adi.sky17@gmail.com>
|
@adisky: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
kind/failing-test
|
@adisky: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-triage
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adisky The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kubernetes-integration |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
I think the problem here is there is a race, i.e the cloud-init scripts are running the containerd installation and k8s setup in parallel. I think the other solution here may be to ensure that the scripts run serially. I think this is what is expected... we should ensure the containerd installation scripts succeeded before attempting to installing k8s. I was testing out a change to do that by modifying the cloudinit- #107800 (comment) The cloudinit that needs to be modified is in containerd repo - https://github.com/containerd/containerd/blob/main/contrib/gce/cloud-init/node.yaml |
Did test succeeed? In containerd I also see With your proposed change, this can be removed, correct? |
|
/hold I think @bobbypage proposal would work more reliable. |
k8s-ci-robot
added
the
do-not-merge/hold
|
@bobbypage lets try your patch, keeping this on hold till then, the reason behind I am proposing this is everything is working serially containerd installation & runtime check if goes by this script, problem occurs when we mix the containerd & k/k scripts, if we are not installing above why to check at this point, possibly we can check for the same in containerd script? |
|
Here is patch on containerd side with adding dependency - containerd/containerd#6544 |
|
closing this, since it is fixed by containerd/containerd#6544 |
|
@adisky: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Aditi Sharma adi.sky17@gmail.com
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Skip container runtime check, if not installed via same script
for this job, we install a custom containerd version using containerd scripts and installation is not complete at the point we are checking https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/configure.sh#L584
jobs which require containerd installation from ubuntu repos always set
KUBE_UBUNTU_INSTALL_CONTAINERD_VERSION, verifying containerd installation here only if we do installation by same method.Which issue(s) this PR fixes:
ref ##107800
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: