Graduate RemoveSelfLink to Stable

[wojtek-t]

Ref kubernetes/enhancements#1164

kube-apiserver: the `metadata.selfLink` field can no longer be populated by kube-apiserver; it was deprecated in 1.16 and has not been populated by default in 1.20+.

/kind feature
/sig api-machinery
/priority important-longerm

Note to reviewers:

There are still some places where SelfLink is used/referenced:

• the API field itself is still part of ObjectMeta and ListMeta (and thus referenced from autogenerated code)
• selfLink accessors are still part of metav1.Object interface (and thus its implementations): https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/meta.go#L33
  the reasoning behind is is that we want to use this method to ensure selflink is cleared before storing an object in etcd: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/storage/etcd3/api_object_versioner.go#L64
  If we can somehow ensure that selfink will be cleared and remove those accessors from the interface, I would like to hear a suggestion
• rbac helpers: https://github.com/kubernetes/kubernetes/blob/master/pkg/registry/rbac/helpers.go#L46
• AsPartialObjectMetadata: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/api/meta/meta.go#L112
• ResetObjectMetaForStatus: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/helpers.go#L263
• StripMetaManaged (fieldManager): https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager/stripmeta.go#L46
• applyconfigurations to ensure that selflink-related methods are not generated [added in this PR]

[k8s-ci-robot]

@wojtek-t: The label(s) priority/important-longerm cannot be applied, because the repository doesn't have them.

In response to this:

Ref kubernetes/enhancements#1164

SelfLink field support is now removed from kube-apiserver.

/kind feature
/sig api-machinery
/priority important-longerm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wojtek-t]

@liggitt - thanks; PTAL

[wojtek-t]

@liggitt - thanks; PTAL

[liggitt]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• api/OWNERS [liggitt]
• pkg/api/OWNERS [liggitt]
• pkg/printers/OWNERS [liggitt,wojtek-t]
• staging/src/k8s.io/apiextensions-apiserver/OWNERS [liggitt,wojtek-t]
• staging/src/k8s.io/apimachinery/pkg/OWNERS [liggitt,wojtek-t]
• staging/src/k8s.io/apimachinery/pkg/apis/OWNERS [liggitt]
• staging/src/k8s.io/apiserver/OWNERS [liggitt,wojtek-t]
• staging/src/k8s.io/client-go/OWNERS [liggitt,wojtek-t]
• staging/src/k8s.io/code-generator/OWNERS [liggitt,wojtek-t]
• staging/src/k8s.io/kube-aggregator/OWNERS [liggitt,wojtek-t]
• staging/src/k8s.io/sample-apiserver/OWNERS [liggitt,wojtek-t]
• staging/src/k8s.io/sample-controller/OWNERS [liggitt,wojtek-t]
• test/OWNERS [liggitt,wojtek-t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

/retest

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest